Remove Hyrax::Actors::TransactionalRequest from default middleware
#3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
never-rollback-actor-stack
branch
from
e61d19d
to
449dc6b
Compare
no-reply
force-pushed
the
never-rollback-actor-stack
branch
2 times, most recently
from
2394adb
to
84e7296
Compare
The actor stack involves writing to several diffrent persistence layers; at least: - ActiveRecord - ActiveFedora (Fedora/Solr) - ActiveJob The transactionality provided by `Hyrax::Actors::TransactionalRequest` addresses only one of these (ActiveRecord). Routinely, failures in the actor stack that trigger transaction rollback there lead to broken states across the various data stores. Additionally, this rollback is not triggered for the main documented failure API for the stack (returning `false`). Rollback only happens when uncaught errors are propagated to the top of the stack. Since this middleware is problematic and doesn't have a clear documented use case, this proposes its removal. Fixes #3128.
no-reply
force-pushed
the
never-rollback-actor-stack
branch
from
84e7296
to
818ca18
Compare
jeremyf
approved these changes
Jan 29, 2019
cjcolvar
added a commit
that referenced
this pull request
Feb 13, 2019
Backwards-compatible backport of #3482
cjcolvar
added a commit
that referenced
this pull request
Feb 18, 2019
Backwards-compatible backport of #3482
no-reply
pushed a commit
that referenced
this pull request
Feb 20, 2019
Backwards-compatible backport of #3482
no-reply
pushed a commit
that referenced
this pull request
Mar 14, 2019
Backwards-compatible backport of #3482
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actor stack involves writing to several diffrent persistence layers; at
least:
The transactionality provided by
Hyrax::Actors::TransactionalRequestaddressesonly one of these (ActiveRecord). Routinely, failures in the actor stack that
trigger transaction rollback there lead to broken states across the various data
stores.
Additionally, this rollback is not triggered for the main documented failure API
for the stack (returning
false). Rollback only happens when uncaught errorsare propagated to the top of the stack.
Since this middleware is problematic and doesn't have a clear documented use
case, this proposes its removal.
Fixes #3128.
@samvera/hyrax-code-reviewers