More i18n omissions #3541

ghost · 2019-02-19T09:01:37Z

Extracts strings from template to allow i18n.

@samvera/hyrax-code-reviewers

ghost · 2019-02-20T13:09:47Z

@jmfrenzel I think you'll want to improve German translations before the branch is merged.
@samvera/hyrax-code-reviewers I think the last test failure (Selenium::WebDriver::Error::WebDriverError) is not related to the changes I made.

cjcolvar · 2019-02-20T13:58:08Z

@j-dornbusch Those errors just came up in a different PR so I'm investigating. Hopefully it can be cleared up soon!

jmfrenzel

Thanks for pinging @j-dornbusch Please consider this changes in your PR.
NB: This PR resolves some of missing _i18n listed in #1386

config/locales/hyrax.de.yml

jmfrenzel · 2019-02-20T15:52:41Z

NB: This PR resolves some of missing _i18n listed in #1386

cjcolvar · 2019-02-20T17:36:34Z

@j-dornbusch ~~If you rebase from master, you'll get #3548 which should fix the failing tests due to chromedriver.~~ The chromedriver issue is still being sorted out. I'll comment here once there is a solution.

cjcolvar · 2019-02-27T17:42:24Z

@j-dornbusch The chromedriver issue should be solved for now so I think it should pass CI if you rebase this PR on master.

Translate title in file show page. Translate "Depositor" in file show page. Translate fields in file show page. Case problem Translate actions in file show page. Translate "sort and per page" for collections show view in back office Translate "sort and per page" for collections show view in front office Translate title in "sort and per page" for collections show view in front office Page crashes in french because of missing entries in i18n file Fix test failing with "translation missing: en.hyrax.collections.sort_and_per_page.html.erb.sort_by_html" Translate "choose file" in collection branding tab Translate delete banner controls in collection branding tab Translate second "choose file" in collection branding tab Translate "link url" in collection branding tab Translate "alt text", "link url", "previous" in collection branding tab Translate search controles in collection sharing tab Translate roles in collection sharing tab Fix test failing with "translation missing: en.hyrax.collections.sort_and_per_page.html.erb.sort_by_html" German translations improvements

ghost · 2019-02-28T05:09:23Z

@cjcolvar Here, there are no more failures on circleci.

cjcolvar · 2019-02-28T14:44:35Z

@j-dornbusch This is looking good but it looks like your squashed rebase includes the chromedriver commit. That should already be in master so it should be removed from your commit and the build should still pass.

ghost · 2019-02-28T16:47:32Z

@cjcolvar Did I squash too many commits ? I tried to cancel the squash but I'm not sure of the result.

cjcolvar · 2019-02-28T17:49:02Z

That took care of the CI build changes that leaked in, but now it looks like something got lost since there are failing tests in spec/features/collection_multi_membership_spec.rb.

ghost · 2019-03-01T08:01:40Z

@cjcolvar I can't reproduce the test failure locally.

rspec ./spec/features/collection_multi_membership_spec.rb
...
Finished in 1 minute 1.9 seconds (files took 4 seconds to load)
8 examples, 0 failures

I'm on the right branch, everything has been pushed.
git status

On branch more-i18n-omissions
Your branch is up-to-date with 'origin/more-i18n-omissions'.

cjcolvar · 2019-03-01T11:48:08Z

👍 I restarted the build. Let's see what happens this time.

cjcolvar · 2019-03-01T13:45:01Z

There are still 3 failures but slightly different than last time. I'm going to see what I can find out by testing locally.

cjcolvar · 2019-03-01T14:24:33Z

Locally, I'm occasionally seeing one failing test in the collection_multi_membership_spec but not the others so I'm rerunning the build again now to see if we can get a passable build so this can be merged. At that point I'll create an issue for the randomly failing test.

cjcolvar · 2019-03-01T21:39:26Z

Now circle is saying the opposite: only the two service tests are failing:
./spec/services/hyrax/embargo_service_spec.rb:33
./spec/services/hyrax/lease_service_spec.rb:33

@samvera/hyrax-code-reviewers Anyone else have ideas about this?

cjcolvar · 2019-03-04T18:29:25Z

I'm guessing that this is failing for the same reasons as the embargo and lease services are failing in hydra-access-controls: https://travis-ci.org/samvera/hydra-head/jobs/501631455
I'm going to dig into this more now since it could be breaking all new hydra-head dependent apps.

Use [* TO *] to work with old and new versions of AF and Solr

cjcolvar · 2019-03-06T03:35:18Z

@j-dornbusch #3559 got merged. Do you mind rebasing one more time?

Translate title in file show page. Translate "Depositor" in file show page. Translate fields in file show page. Case problem Translate actions in file show page. Translate "sort and per page" for collections show view in back office Translate "sort and per page" for collections show view in front office Translate title in "sort and per page" for collections show view in front office Page crashes in french because of missing entries in i18n file Fix test failing with "translation missing: en.hyrax.collections.sort_and_per_page.html.erb.sort_by_html" Translate "choose file" in collection branding tab Translate delete banner controls in collection branding tab Translate second "choose file" in collection branding tab Translate "link url" in collection branding tab Translate "alt text", "link url", "previous" in collection branding tab Translate search controles in collection sharing tab Translate roles in collection sharing tab Fix test failing with "translation missing: en.hyrax.collections.sort_and_per_page.html.erb.sort_by_html" German translations improvements

into more-i18n-omissions

ghost · 2019-03-06T04:04:46Z

@cjcolvar I rebased and force-pushed.

git checkout master
git fetch upstream
git rebase upstream/master
git checkout more-i18n-omissions
git rebase master
git push --force

ghost · 2019-03-06T04:41:05Z

@cjcolvar I can reproduce the "spec/features/work_show_spec.rb" failure locally, so I will investigate it.

ghost · 2019-03-06T05:09:37Z

@cjcolvar The test fails randomly locally, but very rarely. By setting breakpoints, I do not notice anything particular. I can not fail it in debug mode, it still succeeds.

cjcolvar · 2019-03-06T18:19:40Z

Somehow that rebase brought in my commits to master from #3559. I think those should be removed and I'll restart the circle build until it is green.

cjcolvar · 2019-03-22T13:32:34Z

@j-dornbusch Is there anything I can do to help resolve the git history issue and help this get merged? Would you like me to make a new PR with the rebase reapplied?

ghost · 2019-03-22T15:08:28Z

Yes @cjcolvar this PR is now old and we have some tickets on our Hyrax instance that depend on it. If you have a solution I will be grateful.

cjcolvar · 2019-03-27T07:14:21Z

Closing now that #3708 was merged.

ghost changed the title ~~Translate "joined on" in profile page.~~ More i18n omissions Feb 19, 2019

jmfrenzel requested changes Feb 20, 2019

View reviewed changes

ghost force-pushed the more-i18n-omissions branch from ae841fa to f24a2c2 Compare February 21, 2019 06:17

jmfrenzel previously approved these changes Feb 21, 2019

View reviewed changes

ghost marked this pull request as ready for review February 21, 2019 15:57

scherztc self-assigned this Feb 27, 2019

joachim.dornbusch@ehess.fr added 2 commits February 27, 2019 19:39

Syntax errors in german translation

c1f7940

ghost dismissed jmfrenzel’s stale review via ff17140 February 27, 2019 18:47

ghost force-pushed the more-i18n-omissions branch from 827d4a0 to ff17140 Compare February 27, 2019 18:47

Case error

ac85acf

ghost force-pushed the more-i18n-omissions branch from 5555360 to ac85acf Compare February 28, 2019 16:41

cjcolvar added 2 commits March 4, 2019 15:20

Work with solr.DatePointField

e2e8271

Work with solr.DatePointField

f453b79

cjcolvar mentioned this pull request Mar 4, 2019

Use [* TO *] to work with old and new versions of AF and Solr #3559

Merged

Merge pull request samvera#3559 from samvera/cjcolvar-patch-2

a0eec48

Use [* TO *] to work with old and new versions of AF and Solr

joachim.dornbusch@ehess.fr added 4 commits March 6, 2019 04:58

Syntax errors in german translation

a6dde0d

Case error

5d92651

Merge branch 'more-i18n-omissions' of https://github.com/dsi-ehess/hyrax

47bed6a

into more-i18n-omissions

cjcolvar mentioned this pull request Mar 22, 2019

Extract and translate strings. #3708

Merged

cjcolvar closed this Mar 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More i18n omissions #3541

More i18n omissions #3541

ghost commented Feb 19, 2019

ghost commented Feb 20, 2019

cjcolvar commented Feb 20, 2019

jmfrenzel left a comment

jmfrenzel commented Feb 20, 2019

cjcolvar commented Feb 20, 2019 •

edited

Loading

cjcolvar commented Feb 27, 2019

ghost commented Feb 28, 2019

cjcolvar commented Feb 28, 2019

ghost commented Feb 28, 2019

cjcolvar commented Feb 28, 2019

ghost commented Mar 1, 2019

cjcolvar commented Mar 1, 2019

cjcolvar commented Mar 1, 2019

cjcolvar commented Mar 1, 2019

cjcolvar commented Mar 1, 2019

cjcolvar commented Mar 4, 2019

cjcolvar commented Mar 6, 2019

ghost commented Mar 6, 2019

ghost commented Mar 6, 2019

ghost commented Mar 6, 2019

cjcolvar commented Mar 6, 2019

cjcolvar commented Mar 22, 2019

ghost commented Mar 22, 2019

cjcolvar commented Mar 27, 2019

More i18n omissions #3541

More i18n omissions #3541

Conversation

ghost commented Feb 19, 2019

ghost commented Feb 20, 2019

cjcolvar commented Feb 20, 2019

jmfrenzel left a comment

Choose a reason for hiding this comment

jmfrenzel commented Feb 20, 2019

cjcolvar commented Feb 20, 2019 • edited Loading

cjcolvar commented Feb 27, 2019

ghost commented Feb 28, 2019

cjcolvar commented Feb 28, 2019

ghost commented Feb 28, 2019

cjcolvar commented Feb 28, 2019

ghost commented Mar 1, 2019

cjcolvar commented Mar 1, 2019

cjcolvar commented Mar 1, 2019

cjcolvar commented Mar 1, 2019

cjcolvar commented Mar 1, 2019

cjcolvar commented Mar 4, 2019

cjcolvar commented Mar 6, 2019

ghost commented Mar 6, 2019

ghost commented Mar 6, 2019

ghost commented Mar 6, 2019

cjcolvar commented Mar 6, 2019

cjcolvar commented Mar 22, 2019

ghost commented Mar 22, 2019

cjcolvar commented Mar 27, 2019

cjcolvar commented Feb 20, 2019 •

edited

Loading