-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
input form has title as single entry, but the title def stays multiple #3554
Conversation
This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions. |
.viewer-wrapper { | ||
height: 640px; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files should end with a trailing newline
height: 100%; | ||
padding: 10px; | ||
width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered height, left, position, top, width
} | ||
|
||
.viewer { | ||
.viewer-wrapper iframe { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge rule .viewer-wrapper iframe
with rule on line 2
33ff229
to
c191332
Compare
This change breaks our instance because we previously had a multivalued 'title' field (with language support) and another multivalued 'alternative_title' field (with language support) based on dc: alternative. From a documentary point of view, 'title' and 'alternative title' are two separate fields, and each one is likely to receive several values in case of translation of the content. So the mechanism that copies a field into the other will cause problems over time if increased support of the multilingual is introduced. |
### Description Fix bug where `@attributes["alternative_title"] << value` throws an exception because `@attributes["alternative_title"]` is nil. This happens when a model does not include basic metadata causing alternative_title to not be defined. ### Related work: * Issue #4318 - reconsidering impact of PR #3554 * PR #3554 - separates multiple titles into title and alternative titles
### Description Fix bug where `@attributes["alternative_title"] << value` throws an exception because `@attributes["alternative_title"]` is nil. This happens when a model does not include basic metadata causing alternative_title to not be defined. ### Related work: * Issue #4318 - reconsidering impact of PR #3554 * PR #3554 - separates multiple titles into title and alternative titles
Fixes #3299
Title will now be displayed as a single entry in the work form. It remains defined as a multiple ( array ), but in the edit form, it is treated as a single. In cases where a work has more than one title, the titles are sorted alphabetically and the 1st in the list is displayed on the edit form. User collections and admin sets presently display only a single title, but because there is a lot of overlap in the form processing of works and collections, the work form and admin form processing had to change too.
In cases of multiple titles, in order to store values not being displayed on the form, a new metadata type called alt_title was created. This metadata is never displayed but is used during the processing of the form to store the titles not being displayed by the form and then when the form is saved, saving these titles back in the title metadata.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Testing multiple titles for a work:
@samvera/hyrax-code-reviewers