[WIP] move alternative title to core metadata to avoid nil error #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description Fix bug where `@attributes["alternative_title"] << value` throws an exception because `@attributes["alternative_title"]` is nil. This happens when a model does not include basic metadata causing alternative_title to not be defined. ### Related work: * Issue #4318 - reconsidering impact of PR #3554 * PR #3554 - separates multiple titles into title and alternative titles
|
Thank you for putting this step forward and bringing this for conversation and clarification. Based on Samvera Tech discussion, we view #4318 as a blocker, and will close this out. The Reforms style should simplify this behavior (pre-populators and transformations are natively baked in). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug where
@attributes["alternative_title"] << valuethrows an exception because@attributes["alternative_title"]is nil. This happens when a model does not include basic metadata causing alternative_title to not be defined.Related work:
@samvera/hyrax-code-reviewers