Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display analytics without having to refresh browser. #4170

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Conversation

blancoj
Copy link
Contributor

@blancoj blancoj commented Dec 4, 2019

Fixes #3970

When viewing a work's analytics or a file's analytics prior to this change, you would have to refresh the browser page to get the graphs to show.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Go to a work's show page and select the Analytics button.
  • Verify you see the graph with some details, not just completely empty.
  • Go to a work's file detail page and select Analytics button.
  • Verify you see the graph with some details, not just completely empty.

@samvera/hyrax-code-reviewers

@no-reply
Copy link
Contributor

no-reply commented Jan 2, 2020

@blancoj can you comment on why the turbolinks directive fixes this issue?

i think it's necessary to get some description of how this fixes the issue---or how turbolinks caused it---into the commit message. this fix seems exceedingly likely to regress if there are no breadcrumbs for future developers.

@blancoj
Copy link
Contributor Author

blancoj commented Jan 6, 2020

@no-reply I just put in a comment and changed the commit message. Your suspicion about this change being lost was right, since when I was tracking down the solution, I came across this:
#1746

@no-reply
Copy link
Contributor

@blancoj thanks! i never would have guessed that this had already happened, but it makes sense. i can recall a lot of bulk turbolinks edits in the somewhat recent past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics graph is not getting displayed in Safari/Chrome Mac sometimes
2 participants