Add a ChildTypes to manage selection display during work attachment
#4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
valkyrie-presenters
branch
from
43fc3d5
to
c34dc0d
Compare
no-reply
changed the title
ChildTypes to manage selection display during work attachment
no-reply
force-pushed
the
valkyrie-presenters
branch
from
4fe159c
to
072a77a
Compare
added 4 commits
January 14, 2020 08:44
This mixin was previously untested and will need to change to support `Valkyrie`. To get ready for the changes, test it against a minimal compatible class.
With `ActiveFedora` models, we use `MyWork.valid_child_concerns` to determine which types the user can select to attach to an existing work. Since this is a display-only issue, we break this out into a new service. For legacy models, we delegate the configuration back to the model, avoiding any need for configuration changes. For Valkyrie models, we provide a default config (a work can nest works of its own type), but punt on configuration issues. There are other configuration matters to discuss.
This method isn't releted to the `ModelProxy` concern. It is deprecated, with the relevant implementation moved to `WorkShowPresenter`.
Avoid duplicated implementation in for model name/partial path resoultion. These can be safely delegated to `SolrDocument`, which has its own handling for these issues. While we're here, remove the `_delegated_to` cache.
no-reply
force-pushed
the
valkyrie-presenters
branch
from
072a77a
to
926eaec
Compare
jeremyf
reviewed
Jan 22, 2020
no-reply
commented
Jan 22, 2020
jeremyf
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
ActiveFedoramodels, we useMyWork.valid_child_concernsto determinewhich types the user can select to attach to an existing work.
Since this is a display-only issue, we break this out into a new service. For
legacy models, we delegate the configuration back to the model, avoiding any
need for configuration changes.
For Valkyrie models, we provide a default config (a work can nest works of its
own type), but punt on configuration issues. There are other configuration
matters to discuss.
@samvera/hyrax-code-reviewers