deprecate CollectionType#collections?
#4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 13, 2020 13:35
adjust semantics of collection checking from `#count.positive?` to `#any?`. for most enumerables, `#count.positive?` will involve touching all the objects in the enumerator. instead, use `#any?` which lets the enumerator optimize checking for presence. while we're at it, deprecate the entire method and advise users to use `#any?` instead.
no-reply
force-pushed
the
collection-type-count
branch
from
c826bef
to
5639fac
Compare
jeremyf
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust semantics of collection checking from
#count.positive?to#any?. formost enumerables,
#count.positive?will involve touching all the objects in theenumerator. instead, use
#any?which lets the enumerator optimize checking forpresence.
while we're at it, deprecate the entire method and advise users to use
#any?instead.
@samvera/hyrax-code-reviewers