Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate CollectionType#collections? #4434

Merged
merged 2 commits into from
Jul 13, 2020
Merged

deprecate CollectionType#collections? #4434

merged 2 commits into from
Jul 13, 2020

Commits on Jul 13, 2020

  1. deprecate CollectionType#collections? 

    adjust semantics of collection checking from `#count.positive?` to `#any?`. for
most enumerables, `#count.positive?` will involve touching all the objects in the
enumerator. instead, use `#any?` which lets the enumerator optimize checking for
presence.

while we're at it, deprecate the entire method and advise users to use `#any?`
instead.
    tamsin johnson committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    21170aa View commit details
    Browse the repository at this point in the history

  2. refactor CollectionTypeForm specs to test stubbed behavior

    tamsin johnson committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    5639fac View commit details
    Browse the repository at this point in the history