don't break on UrlHelper load if models aren't ActiveModel conformant #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
no-track-paths-for-old-models
branch
2 times, most recently
from
8475f46
to
2a8fda5
Compare
not all possible `registered_curation_concern_types` (or `FileSet`s or `Collection`s) have a model name. likewise, `registered_curation_concern_types` contains strings, which might not be constantizable by mistake. if the rest of the application works under these conditions, just skip defining track paths. note that this module is eagerly loaded and run (only in production, for usual app configurations!) even if it's not included anywhere in the downstream application. this is a bad time to break someone's app on startup over code they didn't load themselves.
jeremyf
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not all possible
registered_curation_concern_types(orFileSets orCollections) have a model name. likewise,registered_curation_concern_typescontains strings, which might not be constantizable by mistake. if the rest of
the application works under these conditions, just skip defining track paths.
note that this module is eagerly loaded and run (only in production, for usual
app configurations!) even if it's not included anywhere in the downstream
application. this is a bad time to break someone's app on startup over code they
didn't load themselves.
@samvera/hyrax-code-reviewers