Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't break on UrlHelper load if models aren't ActiveModel conformant #4848

Merged
merged 1 commit into from
Apr 2, 2021
Merged

don't break on UrlHelper load if models aren't ActiveModel conformant #4848

merged 1 commit into from
Apr 2, 2021

Commits on Apr 2, 2021

  1. don't break on UrlHelper load if models aren't ActiveModel conformant 

    not all possible `registered_curation_concern_types` (or `FileSet`s or
`Collection`s) have a model name. likewise, `registered_curation_concern_types`
contains strings, which might not be constantizable by mistake. if the rest of
the application works under these conditions, just skip defining track paths.

note that this module is eagerly loaded and run (only in production, for usual
app configurations!) even if it's not included anywhere in the downstream
application. this is a bad time to break someone's app on startup over code they
didn't load themselves.
    tamsin johnson committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    2a8fda5 View commit details
    Browse the repository at this point in the history