wings: remove deprecated classes #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunn
previously approved these changes
Jun 22, 2022
no-reply
force-pushed
the
wings-deprecations
branch
from
b51060a
to
839a406
Compare
we don't recommend using FileActor with Valkyrie. there's no need for this compatibility branch; it was deprecated for removal during the 3.x series.
no-reply
force-pushed
the
wings-deprecations
branch
5 times, most recently
from
14e0c1c
to
45ec054
Compare
added 3 commits
June 22, 2022 14:42
remove deprecated behavior from FileSetActor. this code was never recommended for production use, so impact should be very small.
this handling was totally duplicative of the other branch. which branch was used was set by application config. removal should only impact users who might be trying to use the Actor Stack with global valkyrie config turned on and Wings disabled; but this should fail much earlier in the stack, and cause so many other issues that maintaining this code seems undesirable.
support for these is to be dropped in 4.0.0.
dunn
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for these is to be dropped in 4.0.0.
@samvera/hyrax-code-reviewers