Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wings: remove deprecated classes #5723

Merged
merged 4 commits into from
Jun 23, 2022
Merged

wings: remove deprecated classes #5723

merged 4 commits into from
Jun 23, 2022

Commits on Jun 22, 2022

  1. remove use_valkyrie: branch from FileActor 

    we don't recommend using FileActor with Valkyrie. there's no need for this
compatibility branch; it was deprecated for removal during the 3.x series.
    tamsin johnson committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    660149d View commit details
    Browse the repository at this point in the history

  2. remove use_valkyrie branch from FileSetActor 

    remove deprecated behavior from FileSetActor. this code was never recommended
for production use, so impact should be very small.
    tamsin johnson committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    54916c3 View commit details
    Browse the repository at this point in the history

  3. remove valkyrie handling from CreateWithRemoteFilesActor 

    this handling was totally duplicative of the other branch. which branch was used
was set by application config. removal should only impact users who might be
trying to use the Actor Stack with global valkyrie config turned on and Wings
disabled; but this should fail much earlier in the stack, and cause so many
other issues that maintaining this code seems undesirable.
    tamsin johnson committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    c9443fe View commit details
    Browse the repository at this point in the history

  4. wings: remove deprecated classes 

    support for these is to be dropped in 4.0.0.
    tamsin johnson committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    45ec054 View commit details
    Browse the repository at this point in the history