remove deprecated code from FileMetadata #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
filemetadata-deprecation
branch
from
73d3df0
to
a0e0b25
Compare
dlpierce
reviewed
Jul 28, 2022
dlpierce
force-pushed
the
filemetadata-deprecation
branch
from
41cdc48
to
6fd2734
Compare
5 tasks
a lingering call from a private method is replaced to accomplish this, we probably want to backport that replacement.
After the removal of `.for` these metadata fields are no longer being set. This change moves them to their own spec in the context where a file is being attached.
dlpierce
force-pushed
the
filemetadata-deprecation
branch
from
6fd2734
to
eb8055f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lingering call from a private method is replaced to accomplish this, we probably want to backport that replacement.
@samvera/hyrax-code-reviewers