Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated code from FileMetadata #5727

Merged
merged 3 commits into from
Nov 11, 2022
Merged

remove deprecated code from FileMetadata #5727

merged 3 commits into from
Nov 11, 2022

Commits on Nov 11, 2022

  1. remove deprecated code from FileMetadata 

    a lingering call from a private method is replaced to accomplish this, we
probably want to backport that replacement.
    @dlpierce
    tamsin johnson authored and dlpierce committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    e019a83 View commit details
    Browse the repository at this point in the history

  2. Move metadata expectation to its own spec 

    After the removal of `.for` these metadata fields are no longer being set. This change moves them to their own spec in the context where a file is being attached.
    @dlpierce
    dlpierce committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    eb8055f View commit details
    Browse the repository at this point in the history

  3. Use FileMetadata.new in spec

    @dlpierce
    dlpierce committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    4861b06 View commit details
    Browse the repository at this point in the history