Make Google Private Key accessible from the ENV. #6063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys and dynamic configuration for Hyku easier.
orangewolf
force-pushed
the
allow_setting_analytics_key_by_value
branch
from
79e1782
to
b080954
Compare
alishaevn
requested changes
May 16, 2023
orangewolf
force-pushed
the
allow_setting_analytics_key_by_value
branch
from
d745ffc
to
d22e784
Compare
alishaevn
requested changes
May 17, 2023
…ct analytics values and not just the keys
alishaevn
force-pushed
the
allow_setting_analytics_key_by_value
branch
from
4b8ea4c
to
1666cbd
Compare
add some formatting and a todo
alishaevn
force-pushed
the
allow_setting_analytics_key_by_value
branch
from
3a2b15e
to
b82e3e7
Compare
fix the broken specs in analytics_spec.rb
alishaevn
reviewed
May 23, 2023
| ENV['GOOGLE_OAUTH_APP_NAME'] = 'My App Name' | ||
| ENV['GOOGLE_OAUTH_APP_VERSION'] = '0.0.1' | ||
| ENV['GOOGLE_OAUTH_PRIVATE_KEY_PATH'] = '/tmp/privkey.p12' | ||
| ENV['GOOGLE_OAUTH_PRIVATE_KEY_VALUE'] = '' |
There was a problem hiding this comment.
added this line. the rest of the env changes are unifying them with single quotes.
alishaevn
approved these changes
May 24, 2023
aprilrieger
approved these changes
May 24, 2023
alishaevn
added a commit
to samvera/hyku
that referenced
this pull request
Jun 15, 2023
we are using a hyrax version that does not include the code from samvera/hyrax#6063. we can remove this file once that code has been included in another hyrax release and we are using that release version, or higher.
dlpierce
added a commit
that referenced
this pull request
Jun 15, 2023
7 tasks
dlpierce
added a commit
that referenced
this pull request
Jun 23, 2023
Backport #6063 (Google privkey in ENV) to 3.x
orangewolf
added a commit
that referenced
this pull request
Jul 4, 2023
orangewolf
added a commit
that referenced
this pull request
Jul 4, 2023
dlpierce
pushed a commit
that referenced
this pull request
Jul 25, 2023
add priv key from env for GA 4. Copies #6063 to the new GA4 code
orangewolf
added a commit
that referenced
this pull request
Jul 26, 2023
* add priv key from env for GA 4. Copies #6063 to the new GA4 code
Closed
orangewolf
added a commit
that referenced
this pull request
May 17, 2024
* add priv key from env for GA 4. Copies #6063 to the new GA4 code
orangewolf
added a commit
that referenced
this pull request
May 17, 2024
differentiate between collecting and reporting google analytics.
dlpierce
added a commit
that referenced
this pull request
May 24, 2024
* Google Analytics 4 reporting support * add priv key from env for GA 4 (#6107) * add priv key from env for GA 4. Copies #6063 to the new GA4 code * add priv key from env for GA 4. Copies #6063 to the new GA4 code differentiate between collecting and reporting google analytics. * clean up merge * remove ga4 bleed over from this pr --------- Co-authored-by: Daniel Pierce <dlpierce@indiana.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes K8S deploys and dynamic configuration for Hyku easier.
@samvera/hyrax-code-reviewers