Divide analytics collecting and reporting

[orangewolf]

Summary

differentiate between collecting and reporting google analytics. Takes over for #6109. In order to use analytics reporting after this change, you must set HYRAX_ANALYTICS_REPORTING or Hyrax.config.analytics_reporting. Otherwise reporting will be off. This is in addition to HYRAX_ANALYTICS or Hyrax.config.analytics which now controls whether analytics are collected.

@samvera/hyrax-code-reviewers

[github-actions]

Test Results

    9 files  ±0      9 suites  ±0   16m 32s ⏱️ -12s
4 763 tests ±0  4 700 ✅ ±0  63 💤 ±0  0 ❌ ±0 
6 489 runs  ±0  6 426 ✅ ±0  63 💤 ±0  0 ❌ ±0 

Results for commit 2d8d616. ± Comparison against base commit 7197138.

This pull request removes 100 and adds 100 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fad96d56560>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fad96903e90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: f2f5b445-07f5-443f-bbcc-69fa9fb4de08
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 6b87fd83-084c-468c-836e-be3c63934657
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 995fe4ec-e366-48e3-bd42-a3cf43c6aa3c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create #<Hyrax::PermissionTemplate:0x00007fad95d3c940>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fad96146e00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to destroy Hyrax::AdministrativeSet: 93a6b811-6d5e-4297-a325-b13672746bf2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to edit Hyrax::AdministrativeSet: 50915381-f529-4fb9-aa7c-ce6d1ed4b67e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to update Hyrax::AdministrativeSet: 07aacb90-6e5a-485d-9093-e493a28866a8
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fbbcaa8f150>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fbbcaa82590>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 0c03e273-fc35-4ae2-b771-e6d76b9eb39a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: feca881f-d2eb-450f-ac4c-2f6e8c0cb2cd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 0522b03c-fa34-4aab-830a-9732c3bdb1b4
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create #<Hyrax::PermissionTemplate:0x00007fbbc770c6c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fbbc78662c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to destroy Hyrax::AdministrativeSet: 78b9fa31-e066-4061-87fb-6f5e87daa24d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to edit Hyrax::AdministrativeSet: 2c6c6af4-673c-4e30-b68b-076304790432
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to update Hyrax::AdministrativeSet: b0d43e8e-e175-4049-9447-c6a2703f4cee
…

♻️ This comment has been updated with latest results.