-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove navigation role from collection tabs #6939
Merged
randalldfloyd
merged 1 commit into
main
from
6776-collections-dashboard-page-includes-roles-not-inside-required-context
Nov 1, 2024
Merged
Remove navigation role from collection tabs #6939
randalldfloyd
merged 1 commit into
main
from
6776-collections-dashboard-page-includes-roles-not-inside-required-context
Nov 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 17 files ±0 17 suites ±0 2h 17m 16s ⏱️ - 5m 7s Results for commit 4282d10. ± Comparison against base commit 4e73002. This pull request removes 265 and adds 265 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
randalldfloyd
approved these changes
Nov 1, 2024
randalldfloyd
force-pushed
the
6776-collections-dashboard-page-includes-roles-not-inside-required-context
branch
from
November 1, 2024 13:00
6392df2
to
4282d10
Compare
randalldfloyd
deleted the
6776-collections-dashboard-page-includes-roles-not-inside-required-context
branch
November 1, 2024 13:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6776
Summary
role="navigation"
was removed from<ul class="nav nav-tabs" id="my_nav" role="navigation">
in the collection tabs for accessibility.Type of change (for release notes)
notes-minor
Removes navigation role from unordered list for accessibility@samvera/hyrax-code-reviewers