Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove navigation role from collection tabs #6939

Conversation

rkuehn-uofl
Copy link
Contributor

Fixes

Fixes #6776

Summary

role="navigation" was removed from <ul class="nav nav-tabs" id="my_nav" role="navigation"> in the collection tabs for accessibility.

Type of change (for release notes)

notes-minor Removes navigation role from unordered list for accessibility

@samvera/hyrax-code-reviewers

Copy link

github-actions bot commented Oct 30, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 17m 16s ⏱️ - 5m 7s
 6 717 tests ±0   6 420 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 204 runs  ±0  12 808 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit 4282d10. ± Comparison against base commit 4e73002.

This pull request removes 265 and adds 265 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f5c85c249d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff5272b8d50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f5c85c2ac98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff526dccd00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 424698df-70d1-4d2b-9c5c-3f82f0dd03ea
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 6f6306cb-b3e5-4f1f-b132-d75f29bedde7
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: c27351cd-e8a4-4963-8ac7-68303f6ece31
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 0182063d-fffc-4564-b70d-8bdf279752c2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 6476e89b-b2a1-4d18-99fa-aec9a022506d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: e12198ed-6852-44bf-84c5-fe42162f4cb8
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f4317ab93a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f70cfcda018>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f430a2344d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f70cfcd26d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 797dc9f0-e48b-4fe4-aace-6ec77d77b9be
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 9f1c9255-0348-4bcd-aff4-4774b11ff83f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 38ed44a6-7480-45d6-9783-ef06732b7ef9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 3397fef7-27ae-4743-b2c5-45dcf9646533
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: dca4b3cc-9269-4caf-a6fb-c139622b5d3f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 07cea973-9425-4db7-911a-bdd7d1a5066a
…

♻️ This comment has been updated with latest results.

@randalldfloyd randalldfloyd force-pushed the 6776-collections-dashboard-page-includes-roles-not-inside-required-context branch from 6392df2 to 4282d10 Compare November 1, 2024 13:00
@randalldfloyd randalldfloyd merged commit 5e7f26d into main Nov 1, 2024
22 checks passed
@randalldfloyd randalldfloyd deleted the 6776-collections-dashboard-page-includes-roles-not-inside-required-context branch November 1, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collections dashboard page includes roles not inside required context
2 participants