-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub runner updates #388
Conversation
Only run MacOS tests on beta/master, and only run lowest/highest Python versions on bugfix/feature branches. Should address #387.
Should keep the README badges working still, and have better continuity in the Actions tab on GitHub.
Question for you before I approve this. If I understand everything here correctly the new workflow structure is such that:
Is splitting off main and main-mac necessary? In principle beta should track develop in which case there is little difference and these workflows could be merged. In practice this is only true when |
Thanks for taking a look Corey - you understand the proposed workflow correctly. The reason I split main and main-mac was to avoid the Mac runners stuffing up tests on develop, which I thought was the original intent of #387. Although rereading now, I think you may have just wanted I don't feel too strongly about this. If you think it is cleaner to merge the workflows and don't mind waiting for the Mac tests when we push to develop, I will change that and remerge those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. I'm sold, and this all looks good to me. Merge away!
This includes several quality-of-life and deprecation runner updates and addresses #387.
beta
andmaster
.-latest
, bumping our testing environment to Ubuntu 22.04 from 20.04, Windows 2022 from 2019, and MacOS 12 from 11, and will now track updated environments.v2
tov4
(orv3
in the case ofcache
) for node16 updates, which should remove the node12 deprecation warning we've been getting.As an example, this cuts the current runtime from nearly 2 hours (with the MacOS oversubscription problem) to 13 minutes on this feature branch.