Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPL-110: Group arbitrary tubes #894

Merged
merged 38 commits into from
Nov 8, 2021
Merged

DPL-110: Group arbitrary tubes #894

merged 38 commits into from
Nov 8, 2021

Conversation

sdjmchattie
Copy link
Contributor

@sdjmchattie sdjmchattie commented Oct 28, 2021 •
edited
Loading

Completes most of #793

Changes proposed in this pull request:

  • Add a new page to Limber for creating tube racks.
  • Support scanning in tubes in a list of 16 positions.
  • Check for duplicate scanned messages.
  • Check for tubes that don't match in purpose.

image

@sdjmchattie
Add page for new tube rack
096ae89
@sdjmchattie
Add a top level button to create a new tube rack
2203136
@sdjmchattie
Add JavaScript files for TubesToRack
67801fc
@sdjmchattie
Set up usual Vue construct for new view
0900d2a
@sdjmchattie
Port across new LabwareScan code from Cardinal
4e7d56e
@sdjmchattie
Flesh out tube rack creation UI
4260441
@sdjmchattie
Specify the labware type in the LabwareScan component
3e7dfe4
@sdjmchattie
Fix linting issues
dd7a296
@sdjmchattie
Add tests for labware type in messages and placeholders
8872aba
@sdjmchattie
Change case of new tube rack button
1a42bed
@sdjmchattie
Merge branch 'develop' into DPL-110-group-arbitrary-tubes
448ae5d
@sdjmchattie
Add message about missing UI for tube rack component
2cb25d7
@sdjmchattie
Avoid repetition of the valid message in tube scan validators
624c674
@sdjmchattie
Do some validation of scanned tubes
bc1f18b
@sdjmchattie
Add validity for the Create button
29a99ed
@sdjmchattie
Setup the inclusion of purposes for tubes from SS
4be0eaf
@sdjmchattie
Refactor duplicated methods in ScanValidators
de67b4e
@sdjmchattie
Create a test for valid scan message
cc6f064
@sdjmchattie
Add validation for matching purposes across tubes
fc16b90
@sdjmchattie
Add unit tests for checkMatchingPurposes
9012a55
@sdjmchattie
Force use of single quotes
d236b73
@sdjmchattie
Merge branch 'develop' into DPL-110-group-arbitrary-tubes
46d31c7 
# Conflicts:
#	app/javascript/shared/components/LabwareScan.spec.js
#	app/javascript/shared/components/LabwareScan.vue
#	app/javascript/shared/components/tubeScanValidators.js
#	app/javascript/shared/components/tubeScanValidators.spec.js
@sdjmchattie
Add purpose to tube factory
60f84e5
@sdjmchattie
Add first test for TubesToRack Vue component
05ad666
@sdjmchattie
Add remaining tests for TubeToRack
2f3ea7a
@sdjmchattie sdjmchattie self-assigned this Oct 28, 2021
JamesGlover
JamesGlover reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@JamesGlover JamesGlover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's obviously the controller side stuff still to come, and there's a few questions about dimensions that I suspect are just being deferred for the moment.

app/javascript/shared/components/scanValidators.js Outdated Show resolved Hide resolved
app/javascript/tubes-to-rack/components/TubesToRack.vue Outdated Show resolved Hide resolved
app/javascript/tubes-to-rack/components/TubesToRack.vue Outdated Show resolved Hide resolved
app/javascript/shared/components/tubeScanValidators.js Outdated Show resolved Hide resolved
app/javascript/tubes-to-rack/components/TubesToRack.vue Outdated Show resolved Hide resolved
app/javascript/tubes-to-rack/components/TubesToRack.vue Show resolved Hide resolved
@sdjmchattie
Merge branch 'DPL-110-group-arbitrary-tubes' into DPL-110-submit-tube…
4c62165 
…-rack

# Conflicts:
#	app/javascript/tubes-to-rack/components/TubesToRack.vue
JamesGlover
JamesGlover approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@JamesGlover JamesGlover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although may be a good idea to remove the links on this branch before merging, to reduce the risk of it going live.

@codeclimate
Copy link

codeclimate bot commented Nov 8, 2021

Code Climate has analyzed commit 4475640 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 87.1% (0.0% change).

View more on Code Climate.

@sdjmchattie sdjmchattie merged commit 5c83d74 into develop Nov 8, 2021
@sdjmchattie sdjmchattie deleted the DPL-110-group-arbitrary-tubes branch November 8, 2021 13:53
@KatyTaylor KatyTaylor mentioned this pull request Aug 17, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesGlover JamesGlover JamesGlover approved these changes

@stevieing stevieing Awaiting requested review from stevieing

@KatyTaylor KatyTaylor Awaiting requested review from KatyTaylor

Assignees

@sdjmchattie sdjmchattie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdjmchattie @JamesGlover