Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix numeric datasets being treated as missing #423

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Dec 12, 2017

If you have a numeric dataset name, say 2018, certain dataset commands will fail because the CLI casts it to a number. When fetching available datasets and comparing it with a strict equals operator, it misses. This PR manually casts all dataset names to strings.

Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rexxars rexxars merged commit 1e0969f into next Dec 13, 2017
@rexxars rexxars deleted the fix-numeric-dataset branch December 13, 2017 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants