-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Discussion about iplot method #109
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Guillaume <jeusel.guillaume@gmail.com>
|
Wow ! I didn't knew that. But surprise, look at what's written:
|
So long as they match I don't think anyone will mind. |
I like the idea, as this will clean up the code, and will also make the documentation in #107 much clearer! |
Yes the idea was to math the It was also meant to be for very quick charting, where arguments are interchangeable across chart types (which is not entirely the case in However, I agree the code in I like the idea of having a method for each figure type. It may be challenging in some instances, as it will seem to overlap with native The This would only apply to regular charts, and not to Let me know what you guys think. |
Well, I've made a litte POC here on how to structure the code. |
really need the type of line char with error-band |
I recently came across cufflinks, and as a daily user of pandas & plotly, I've just fallen in love with this idea of linking them together!
Indeed, getting sweet plots quickly with plotly can be a little bit troublesome to my opinion, as there are so many options...
Cufflinks that aims at some kind of standarization for basics plots is just awesome!
What I especially like is the idea about adding a new method
iplot
to every pandas instance.Yet, to handle every and each one cases, the function
cufflinks.plotlytools._iplot
in the code is quite large, and hard to read to my opinion.So I was thinking: maybe decomposing different plots into methods for
pandas.Dataframe.iplot
would be of interest to better the code structure? (And also I find it eases the use of it)What I mean by that:
df.iplot(kind='heatmap')
would becomedf.iplot.heatmap()
df.iplot(kind='scatter')
would becomedf.iplot.heatmap()
And what goes along is an easier handling of all parameters passed to thoses methods.
For the moment, I just put it as optional, and created a jupyter notebook to make my point.
Happy to share about that, cheers