Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default config for offline plot first #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eholic
Copy link
Contributor

@eholic eholic commented Oct 31, 2019

I apologize my last imperfect PRs first. It relates to issue #210 again. cufflinks(fec61cd) without chart_studio may still need cufflinks.go_offline() due to default config here.

_FILE_CONTENT = {

However I edited some default values, it should be discussed by maintainers.

Also, I should mention former cufflinks users may need to clear or review ~/.cufflinks/.config.

@nicolaskruchten
Copy link
Collaborator

I would support this but I'll leave the decision up to @santosjorge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants