Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove decoding base64 log-data step #94

Conversation

0xharshrastogi
Copy link
Contributor

@0xharshrastogi 0xharshrastogi commented Oct 30, 2024

Remove Base64 Decoding from getLogs Method and newLogs Event

This pull request removes the Base64 decoding step from the getLogs method and newLogs event, optimizing the logging process by directly returning the logs in original format.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have updated the README and other relevant documents (guides...)

@sarvalabs-harshrastogi sarvalabs-harshrastogi added providers Issues related to providers bug Something isn't working labels Oct 30, 2024
@sarvalabs-gokul sarvalabs-gokul changed the base branch from develop to refactor/interaction-struct November 15, 2024 09:38
@sarvalabs-gokul sarvalabs-gokul merged commit b504ee2 into sarvalabs:refactor/interaction-struct Nov 15, 2024
sarvalabs-gokul added a commit that referenced this pull request Nov 15, 2024
* feat: modified the interaction object schema

* refactor: replaced logic schema with logic deploy and interact schema

* refactor: added participants to ix object

* feat: improved the logic to process funds and participants.

- updated the documentation with latest interaction structure
- enhanced the participant structure

* refactor: improved the transaction payload type

* refactor: replace transactions with ix_operations

* refactor: added support to encode participant create schema

* refactor: rename transaction payload with operation payload

- rename txtype to optype

* fix: resolve failing test case

* refactor: replaced transaction keyword with operations.

- added participant create info to docs

* refactor: enhanced the logic to call or estimate ixn

* refactor: added with_commit_info arg to get tesseract method

* refactor: updated the get tesseract examples

* fix: remove base64 decoding from new logs (#94)

* fix: resolve `crypto-browserify` global reference error in browser environments (#95)

---------

Co-authored-by: Harsh Rastogi <rastogiharsh04@gmail.com>
Co-authored-by: Harsh Rastogi <harsh.rastogi@sarva.ai>
sarvalabs-gokul added a commit that referenced this pull request Nov 15, 2024
* enhance interaction struct to support multiple operations (#77)

* feat: modified the interaction object schema

* refactor: replaced logic schema with logic deploy and interact schema

* refactor: added participants to ix object

* feat: improved the logic to process funds and participants.

- updated the documentation with latest interaction structure
- enhanced the participant structure

* refactor: improved the transaction payload type

* refactor: replace transactions with ix_operations

* refactor: added support to encode participant create schema

* refactor: rename transaction payload with operation payload

- rename txtype to optype

* fix: resolve failing test case

* refactor: replaced transaction keyword with operations.

- added participant create info to docs

* refactor: enhanced the logic to call or estimate ixn

* refactor: added with_commit_info arg to get tesseract method

* refactor: updated the get tesseract examples

* fix: remove base64 decoding from new logs (#94)

* fix: resolve `crypto-browserify` global reference error in browser environments (#95)

---------

Co-authored-by: Harsh Rastogi <rastogiharsh04@gmail.com>
Co-authored-by: Harsh Rastogi <harsh.rastogi@sarva.ai>
@0xharshrastogi 0xharshrastogi deleted the fix/log-data-format-issue branch November 25, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working providers Issues related to providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants