fix: resolve crypto-browserify global reference error in browser environments
#95
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvalabs-harshrastogi
requested a review
from sarvalabs-gokul
as a code owner
sarvalabs-harshrastogi
added
bug
Deploying js-moi-sdk with
|
| Latest commit: |
69d9667
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://500b2039.js-moi-sdk.pages.dev |
| Branch Preview URL: | https://fix-ws-connect-failed-in-bro.js-moi-sdk.pages.dev |
sarvalabs-harshrastogi
changed the base branch from
develop
to
refactor/interaction-struct
sarvalabs-gokul
approved these changes
Nov 15, 2024
sarvalabs-gokul
added a commit
that referenced
this pull request
Nov 15, 2024
* feat: modified the interaction object schema * refactor: replaced logic schema with logic deploy and interact schema * refactor: added participants to ix object * feat: improved the logic to process funds and participants. - updated the documentation with latest interaction structure - enhanced the participant structure * refactor: improved the transaction payload type * refactor: replace transactions with ix_operations * refactor: added support to encode participant create schema * refactor: rename transaction payload with operation payload - rename txtype to optype * fix: resolve failing test case * refactor: replaced transaction keyword with operations. - added participant create info to docs * refactor: enhanced the logic to call or estimate ixn * refactor: added with_commit_info arg to get tesseract method * refactor: updated the get tesseract examples * fix: remove base64 decoding from new logs (#94) * fix: resolve `crypto-browserify` global reference error in browser environments (#95) --------- Co-authored-by: Harsh Rastogi <rastogiharsh04@gmail.com> Co-authored-by: Harsh Rastogi <harsh.rastogi@sarva.ai>
This was referenced Nov 15, 2024
sarvalabs-gokul
added a commit
that referenced
this pull request
Nov 15, 2024
* enhance interaction struct to support multiple operations (#77) * feat: modified the interaction object schema * refactor: replaced logic schema with logic deploy and interact schema * refactor: added participants to ix object * feat: improved the logic to process funds and participants. - updated the documentation with latest interaction structure - enhanced the participant structure * refactor: improved the transaction payload type * refactor: replace transactions with ix_operations * refactor: added support to encode participant create schema * refactor: rename transaction payload with operation payload - rename txtype to optype * fix: resolve failing test case * refactor: replaced transaction keyword with operations. - added participant create info to docs * refactor: enhanced the logic to call or estimate ixn * refactor: added with_commit_info arg to get tesseract method * refactor: updated the get tesseract examples * fix: remove base64 decoding from new logs (#94) * fix: resolve `crypto-browserify` global reference error in browser environments (#95) --------- Co-authored-by: Harsh Rastogi <rastogiharsh04@gmail.com> Co-authored-by: Harsh Rastogi <harsh.rastogi@sarva.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package failed in browser environments
This pull request resolves the where package is failed in browser environment due to bug in
crypto-browserifypackage. Causing error.The following are the issue we are facing:
Broken on SSR browserify/randombytes#33
globalReference Error in Browser Environment browserify/randombytes#38closes Package fails in browser environments due to
crypto-browserifyglobal reference error labels #96Apart from it update the node version to v20 in github pipelines
Changes include
Checklist