Fix a selector parsing bug in indented syntax #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
requested changes
May 13, 2020
Fixes #1002. In the indented syntax, a selector list may continue onto another line if the previous line ends with a comma. Previously, if there was a comment after the comma, it wouldn't be recognized and the selector would be broken in two (with the first selector having no properties). This fixes the parser to ignore comments when looking for the comma at the end of a line.
jathak
force-pushed
the
comment-parsing-fix
branch
from
492f9fe to
4961a5d
Compare
nex3
approved these changes
Aug 6, 2020
|
Don't forget to add a CHANGELOG entry for this! |
|
Do you know what's going on with Appveyor here? |
|
Looks like possibly a flake? I'll try restarting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1002.
In the indented syntax, a selector list may continue onto another line if the previous line ends with a comma. Previously, if there was a comment after the comma, it wouldn't be recognized and the selector would be broken in two (with the first selector having no properties).
This fixes the parser to ignore comments when looking for the comma at the end of a line.
See sass/sass-spec#1532.