Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for comments within a selector. #1532

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Add specs for comments within a selector. #1532

merged 2 commits into from
Aug 6, 2020

Conversation

jathak
Copy link
Member

@jathak jathak commented May 12, 2020 •
edited
Loading

See sass/dart-sass#1002.

[skip dart-sass]

@jathak jathak mentioned this pull request May 12, 2020
Merged
nex3
nex3 requested changes May 13, 2020
View reviewed changes
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is breaking some LibSass tests. Usually we handle that by filing an issue with them and marking the specs as TODO with that issue number.

spec/css/selector.hrx Outdated Show resolved Hide resolved
@jathak jathak closed this Aug 6, 2020
@jathak jathak force-pushed the comment-parsing-fix branch from 756969a to a51f270 Compare August 6, 2020 20:35
@jathak jathak reopened this Aug 6, 2020
@jathak jathak requested a review from nex3 August 6, 2020 20:38
@jathak jathak mentioned this pull request Aug 6, 2020
Open
@jathak jathak merged commit 5706f13 into master Aug 6, 2020
@jathak jathak deleted the comment-parsing-fix branch August 6, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jathak @nex3