3.2.1 release

[xzyfer]

We'd originally planned to ship 3.2.1 with a handful of minor features and patches once the 3.2.0 dust settled but it appears we've had some show stoppers that weren't caught in our 6 rounds of beta releases.

I propose we ship 3.2.1 asap addressing these issues

• Fix str-slice function to work with utf8 strings #1047
• Fix mathematical operations with different units #1049
• Relax compact error to warning #1055
• Fix order of top nodes (comments and imports) #1138
• variables losing zeros #1140
• Missing #include in util.cpp #1144
• @import url() Failing in 3.2? (possible regression) #1145 (Seems to truncate line and fail to compile SCSS #1146, Allow more valid ascii chars for url parsing #1147)
• Expose string is_quoted flag for C-API #1148
• Double free() fault sassc#105

Thoughts and feels? @mgreter @hcatlin

[xzyfer]

Tracking this in https://github.com/sass/libsass/milestones/hotfix

[mgreter]

Do you want to include the queued and ready PRs for 3.2.1. I basically just wanted to rebase them all when I get to it, but otherwise they should be ready! But we can also do two short follow up releases.

[xzyfer]

I'd rather wait til the dust settings before shipping the 3.2.1 PRs. I'd created a hotfix milestone to track these critical issues.

[mgreter]

We have the following PRs pending:

• Relax compact error to warning #1055 - Relax compact error to warning -> how long we want to keep it an error?
• Fix mathematical operations with different units #1049 - Fix mathematical operations with different/complex units -> probably complex units are broken via C-API #1149
• Fix str-slice function to work with utf8 strings #1047 - Fix str-slice function to work with utf8 strings -> Code looks cleaner and passes tests
• Fix order of top nodes (comments and imports) #1138 - Fix order of top nodes -> Actual fix is rather trivial
• Implement handling of nested :not pseudo selectors #1046 - Implement handling of nested :not pseudo selectors -> minor feature to pass a spec
• Fix separator preserving with rest args #1050 - Fix separator preserving with rest args -> needs check since we did some work there IMO

IMO we should at least consider the first 4 PR for the next minor release!
There is basically just one main change comming with #1049, but that is an actual bug fix and implements something that did not work previousely, and it seems related to #1149.

[xzyfer]

I think we should abandon #1055 in favour of removing all traces to compact. I expect the amount of people relying on this is approaching 0.

I'm 👍 to shipping the other three. The last two can wait IMO.

[mgreter]

I can rebase to get a new CI run ...

[xzyfer]

I've renamed the 3.2.1 milestone to 3.2.2
I've renamed the hotfix milestone to 3.2.1
I've reassigned #1049, #1047, #1138 to the 3.2.1

[xzyfer]

🚢

[xzyfer]

@mgreter whilst I have your attention can you please jump into Slack and check my message? :)

[onedayitwillmake]

Any word on the selector functions?

[xzyfer]

@onedayitwillmake this a hotfix release to address some critical issues that came up in 3.2.0.

Selectors will land in our next major release.