Fix mathematical operations with different units #1049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mathematical operations with different units:
Could move
convert
function back tonormalize
, but I don't think we pay much in terms of performance for keeping them apart for now. Made quite a few wrong turns while implementing that, since I intially wanted to use a map table for the units (like counting exponents). But then it was not able to normalize units the way ruby sass does, as insert order is important for that.So this is not just a cosmetic fix, libsass also calculated wrong results in certain situations (see changes in eval.cpp). I do hope this is on par with ruby sass now 😉
Makes it pass this spec test:
IMO it's only missing (optional) performance optimizations!