Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of top nodes (comments and imports) #1138

Merged
merged 1 commit into from
Apr 30, 2015

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Apr 26, 2015

Fixes #1080

@mgreter mgreter self-assigned this Apr 26, 2015
@mgreter mgreter added this to the 3.2.1 milestone Apr 26, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 80.26% when pulling 6f50613 on mgreter:bugfix/issue_1080 into 89338a7 on sass:master.

@HamptonMakes
Copy link
Member

Interestingly, the test for 1080 passes already... without this commit!

@xzyfer
Copy link
Contributor

xzyfer commented Apr 29, 2015

Might be a sass-spec issue because the output is certainly incorrectly

$ sassc test.scss
/** comment 1 */
@import url("import-1");
@import url("import-2");
/** comment 2 */
/** comment 3 */
foo {
  bar: baz; }

$ sass test.scss
/** comment 1 */
@import url("import-1");
/** comment 2 */
@import url("import-2");
/** comment 3 */
foo {
  bar: baz; }

@HamptonMakes
Copy link
Member

hmmm... what the hell is wrong with my setup...

@mgreter mgreter mentioned this pull request Apr 30, 2015
9 tasks
@xzyfer xzyfer modified the milestones: 3.2.1, 3.2.2 Apr 30, 2015
@mgreter mgreter force-pushed the bugfix/issue_1080 branch from 6f50613 to 94cbc82 Compare April 30, 2015 01:54
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 80.26% when pulling 94cbc82 on mgreter:bugfix/issue_1080 into 9ad775f on sass:master.

xzyfer added a commit that referenced this pull request Apr 30, 2015
Fix order of top nodes (comments and imports)
@xzyfer xzyfer merged commit 1823a09 into sass:master Apr 30, 2015
@mgreter mgreter deleted the bugfix/issue_1080 branch July 28, 2015 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@import placed above comment at beginning of output CSS
4 participants