-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2] Bubble media queries #790
Conversation
8f40e3a
to
50ac1c0
Compare
75dbc16
to
778af5b
Compare
I appear to be having issues with the autotools builds https://travis-ci.org/sass/libsass/jobs/45523757 |
778af5b
to
b2f67f3
Compare
Did you add your new source files to Makefile.am? |
b2f67f3
to
c85248b
Compare
You're right I missed that file. That got me closer now I'm getting
with the |
c85248b
to
7bea4a9
Compare
This is as good as it is gets. It's ready to go in 3.2 as soon as I can track down the compilation error in |
Fails in Windows as well:
so maybe this points you in the right direction. |
vector<Block*> block_stack; | ||
vector<Statement*> p_stack; | ||
|
||
Statement* fallback_impl(AST_Node* n); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably make this public
or protected
, I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
78fa418
to
8e77a8c
Compare
8e77a8c
to
1751f20
Compare
1751f20
to
f69a76b
Compare
Superseded by #800. |
This PR implements bubbling and merging of media queries (#185).
To get this over the line I enlisted the help of @hugogiraudel to buff up our
@media
bubbling spec coverage.TODO
This PR also smartens the logic around when to output some types blocks i.e. never output a ruleset that only has unresolved
%placeholder selectors
. I also fixes some inconsistencies in the nested output for media queries.As a side affect of these fixes the following tests an outstanding @extends spec now also passes.
Bonus
This the
cssize
visitor added will also for the basis of@at-root
!!!This PR is ready to go for 3.2!