-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2] Bubble media queries #800
Conversation
@mgreter any ideas why the I'm not familiar with autotools, and it onl fails on the shared build. This is the only thing holding this PR up. |
You have In short, drop the
so I think it's unused and then optimized out. |
bfbf056
to
db481cb
Compare
Success!! Thanks for the find @QuLogic! I'll clean up this PR tomorrow. |
db481cb
to
01718b1
Compare
f649e4b
to
8d0a12f
Compare
8d0a12f
to
c1eff65
Compare
c1eff65
to
c79ef9f
Compare
This should avoid inconsistent errors like the one that showed up in PR sass#800.
Any ETA on getting this into a release? Stuck with slow ruby-sass because of this bug. |
This will land in 3.2 likely some time in Feb. |
This PR implements bubbling and merging of media queries.
Fixes #185. Specs added sass/sass-spec#215.
To get this over the line I enlisted the help of @hugogiraudel to buff up our
@media
bubbling spec coverage.TODO
As a side affect of these fixes the following tests an outstanding @extends spec now also passes.
Bonus
This the
cssize
visitor added will also for the basis of@at-root
!!!This PR is ready to go for 3.2!