Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor build stuff #805

Merged
merged 2 commits into from
Jan 8, 2015
Merged

Fix some minor build stuff #805

merged 2 commits into from
Jan 8, 2015

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jan 5, 2015

In a6b58f4, the aux directory for autotools stuff was changed to script, but some things (like ignore files) were not updated to this new path.

Secondly, make undefined symbols an error, since it's necessary for Windows anyway. This should make inconsistent failures like in #800 stop occurring (because all builds would fail). I'm not sure if this argument is supported everywhere, so I guess we'll see what happens with the CI...

Autotools scripts are put in script, not the top directory, so update
paths for that.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9c5c26f on QuLogic:build-stuff into 63093c1 on sass:master.

This should avoid inconsistent errors like the one that showed up in
PR sass#800.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 835c3d7 on QuLogic:build-stuff into 63093c1 on sass:master.

@QuLogic
Copy link
Contributor Author

QuLogic commented Jan 5, 2015

Hmm, no AppVeyor? That's really what I was interested in...

@am11
Copy link
Contributor

am11 commented Jan 6, 2015

For some reason, Appveyor is not picking up the webhook. @xzyfer updated the webhook URL in settings.

@FeodorFitsner, can you please tell us besides updating the webhook URL, what else do we need to change to hear back from https://ci.appveyor.com/project/sass/libsass?

@FeodorFitsner
Copy link

  1. make sure webhook URL is from right project 2) have at least "push" and "pull_request" events ticked on webhook settings

  2. check "Recent deliveries" for any non-OK results

-Feodor

On Mon, Jan 5, 2015 at 4:16 PM, Adeel Mujahid notifications@github.com
wrote:

For some reason, Appveyor is not picking up the webhook. @xzyfer updated the webhook URL in settings.

@FeodorFitsner, can you please tell us besides updating the webhook URL, what else do we need to change to hear back from https://ci.appveyor.com/project/sass/libsass?

Reply to this email directly or view it on GitHub:
#805 (comment)

@am11
Copy link
Contributor

am11 commented Jan 6, 2015

Thanks @FeodorFitsner!

@xzyfer, @mgreter, can you please confirm what @FeodorFitsner's has pointed out?

You can find those settings under Appveyor Web Hook settings page on GitHub:

(something like https://github.com/sass/libsass/settings/hooks/ <some-hook-id>)

It looks like:

webhook-settings

@xzyfer
Copy link
Contributor

xzyfer commented Jan 6, 2015

I spent about an hour looking into this. Our setup is exactly the same as node-sass. AppVeyor is pickup the builds, it's just not update the build status. I think issue may be on GH's end... maybe? i dunno

@xzyfer
Copy link
Contributor

xzyfer commented Jan 6, 2015

screen shot 2015-01-06 at 12 06 16 pm

@xzyfer
Copy link
Contributor

xzyfer commented Jan 6, 2015

FWIW @QuLogic this appears to have passed in AppVeyor https://ci.appveyor.com/project/sass/libsass/build/1.0.57

@am11
Copy link
Contributor

am11 commented Jan 6, 2015

Thanks @xzyfer!
@FeodorFitsner, previously the hook was tied to @hcatlin's account: https://github.com/hcatlin/libsass. We updated it to point to https://github.com/sass/libsass when this problem started. Is there any other tip you can provide to relax this situation? :)

@mgreter
Copy link
Contributor

mgreter commented Jan 6, 2015

FYI: I have activated "status" recently in the hope it might solve this ... beside that I have no idea. @xzyfer do you have admin access at appveyor for that repository? Maybe we need some setting there?

@FeodorFitsner
Copy link

Could you paste a screenshot of webhook settings from GitHub?

-Feodor

On Mon, Jan 5, 2015 at 5:13 PM, Marcel Greter notifications@github.com
wrote:

FYI: I have activated "status" recently in the hope it might solve this ... beside that I have no idea. @xzyfer do you have admin access at appveyor for that repository? Maybe we need some setting there?

Reply to this email directly or view it on GitHub:
#805 (comment)

@am11
Copy link
Contributor

am11 commented Jan 6, 2015

@mgreter, you and @xzyfer both are admins. :)

@FeodorFitsner, its right here: #805 (comment)

@xzyfer
Copy link
Contributor

xzyfer commented Jan 6, 2015

FYI: I confirmed our settings are the same as node-sass in both GH and AppVeyor yesterday.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 6, 2015

@mgreter you'll need to log out of AppVeyor and re-login then select sass from the dropdown that appears.

@FeodorFitsner
Copy link

OK, and what's correspondent project at AppVeyor?

-Feodor

On Mon, Jan 5, 2015 at 5:21 PM, Michael Mifsud notifications@github.com
wrote:

@mgreter you'll need to log out of AppVeyor and re-login then select sass from the dropdown that appears.

Reply to this email directly or view it on GitHub:
#805 (comment)

@xzyfer
Copy link
Contributor

xzyfer commented Jan 6, 2015

@mgreter mgreter added the Build label Jan 6, 2015
@FeodorFitsner
Copy link

I see queued builds: https://ci.appveyor.com/project/sass/libsass/history Seems to be OK?

@mgreter
Copy link
Contributor

mgreter commented Jan 6, 2015

@FeodorFitsner The issue is that "CI reports" for PRs are not included. As you can see right below this comment, only Travis-CI reports it's status to the PR: "The Travis CI build passed". Before it read something like "2 out of 2 ..."!

@FeodorFitsner
Copy link

Will take a look.

-Feodor

On Mon, Jan 5, 2015 at 6:24 PM, Marcel Greter notifications@github.com
wrote:

@FeodorFitsner The issue is that "CI reports" are not included. As you can see in #811, only Travis-CI reports it's status to the PR.

Reply to this email directly or view it on GitHub:
#805 (comment)

@QuLogic
Copy link
Contributor Author

QuLogic commented Jan 8, 2015

Since @xzyfer mentioned that this passed on AppVeyor, I guess we can merge this, the missing CI results notwithstanding.

mgreter added a commit that referenced this pull request Jan 8, 2015
@mgreter mgreter merged commit a072560 into sass:master Jan 8, 2015
@QuLogic QuLogic deleted the build-stuff branch January 8, 2015 17:05
@am11
Copy link
Contributor

am11 commented Mar 7, 2015

Following appveyor/ci#157, I had a brief email conversation with @FeodorFitsner and GitHub staff, I have found the solution for AppVeyor hook problem.

Currently, if the owner logon to AppVeyor, select Sass account and browse to https://ci.appveyor.com/account, they will see my account as GitHub authorization. It was set to Andrew's account, I revoked and re-authorize with my account to test whether it keeps the history, which it does.

The issue is neither Andrew nor me are owners of LibSass, but only node-sass. So the solution is simple; either @xzyfer, @mgreter or anyone with Owner role for both node-sass and libsass can logon to https://ci.appveyor.com/account with GitHub creds, select Sass account and click the revoke button under GitHub account then click authorize. This will hook both repos.

@mgreter
Copy link
Contributor

mgreter commented Mar 7, 2015

Thanks for the hint, seems like that did it! #925

@am11
Copy link
Contributor

am11 commented Mar 7, 2015

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants