Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for & in SassScript #966

Merged
merged 1 commit into from
Mar 18, 2015

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Mar 18, 2015

This PR implements using & in SassScript.

Fixes #548. Specs added sass/sass-spec#103, sass/sass-spec#280.

Successor to #965, #959

/cc @ekskimn

@xzyfer xzyfer mentioned this pull request Mar 18, 2015
@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 18, 2015

Once again great work here @ekskimn! I'll merge this once CI passes.

@ekskimn
Copy link

ekskimn commented Mar 18, 2015

Thanks @xyfer, sorry for the pr mess. I tried doing the fixup commit but yeah it ended up being another commit somehow.

@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 18, 2015

No worries! Feel free to join our gitter (https://gitter.im/sass/libsass) and we can catch about how to avoid merge commits :)

Unfortunately the really mess up the git history and make it have to back out changes or forensically figure when something broke.

@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 18, 2015

/cc @am11 can you please check I've Visual Studioed correctly w.r.t Listize?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 80.79% when pulling 6735dd5 on xzyfer:feat/ampersand-in-sassscript into 62314f6 on sass:master.

xzyfer added a commit that referenced this pull request Mar 18, 2015
@xzyfer xzyfer merged commit c15b384 into sass:master Mar 18, 2015
@xzyfer xzyfer deleted the feat/ampersand-in-sassscript branch March 18, 2015 12:27
@mgreter
Copy link
Contributor

mgreter commented Mar 19, 2015

Congrats @ekskimn for such a great contribution. Hope you stay around and would love to see more contributions of that quality. One major feature off the checklist, great stuff!

@am11
Copy link
Contributor

am11 commented Mar 19, 2015

👍 💯
Congrats @ekskimn! 🎉

@xzyfer, I didn't knew that we are keeping libsass.filters in sync too (not even sure what is it for).

@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 19, 2015

@am11 me neither. I just greped for cssize and did the same. I'm pretty sure when I wrote cssize I just greped for expand... etc..

@ekskimn
Copy link

ekskimn commented Mar 19, 2015

@mgreter Most definitely sticking around. Glad to contribute something even if @xzyfer still seems uncomfortable with it. Considering doing #963 next

@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 19, 2015

#963 would be great! I'd make sure to start with a thorough spec suite first.

@geddski
Copy link

geddski commented Mar 27, 2015

sweet! This is the main feature I've been waiting for to be able to use libsass with csstyle. Thanks @xzyfer!

@jesseleite
Copy link

Thank you! PS. Check out geddski's csstyle sometime, it's pretty slick :)

@mgreter mgreter changed the title Implement using & in SassScript Implement support for & in SassScript Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support parent selector & in values / and/or interpolations
7 participants