-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for &
in SassScript
#966
Conversation
Once again great work here @ekskimn! I'll merge this once CI passes. |
Thanks @xyfer, sorry for the pr mess. I tried doing the fixup commit but yeah it ended up being another commit somehow. |
No worries! Feel free to join our gitter (https://gitter.im/sass/libsass) and we can catch about how to avoid merge commits :) Unfortunately the really mess up the git history and make it have to back out changes or forensically figure when something broke. |
/cc @am11 can you please check I've Visual Studioed correctly w.r.t |
Implement using & in SassScript
Congrats @ekskimn for such a great contribution. Hope you stay around and would love to see more contributions of that quality. One major feature off the checklist, great stuff! |
@am11 me neither. I just greped for |
#963 would be great! I'd make sure to start with a thorough spec suite first. |
Thank you! PS. Check out geddski's csstyle sometime, it's pretty slick :) |
&
in SassScript
This PR implements using & in SassScript.
Fixes #548. Specs added sass/sass-spec#103, sass/sass-spec#280.
Successor to #965, #959
/cc @ekskimn