Handle only the required nodes in Listize #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Slightly tangential question, what does listize do? When is it required and when is it not? |
|
Listize turns selectors into Sass lists. It's needed when selectors are being used as Sass values i.e. variables, function/mixin arguments etc. |
xzyfer
changed the title
|
Hi @xzyfer , I took at look at the PR and it makes sense to me. =) 👍 |
|
LGTM 👍 ! Maybe we want to include this in the next beta as is? IMO you can still take it from there! |
mgreter
changed the title
mgreter
added a commit
that referenced
this pull request
Mar 30, 2015
Handle only the required nodes in Listize
|
Merged it beside the concerns given by @xzyfer. IMO this seems to be an improvement and we can add a more precise implementation later. Just want to have this included in the next release! |
|
👍 I have more work to do here but this is a good start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some clean up of the recent
&in SassScript feature #966./cc @ekskimn