Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Drop Node EOL versions support #1709

Closed
4 tasks
nschonni opened this issue Sep 7, 2016 · 10 comments
Closed
4 tasks

Drop Node EOL versions support #1709

nschonni opened this issue Sep 7, 2016 · 10 comments

Comments

@nschonni
Copy link
Contributor

nschonni commented Sep 7, 2016

Since node is dropping it from even security patching https://nodejs.org/en/blog/community/v5-to-v7/

  • Remove from Appveyor
  • Remove from Travis
  • Update install script to print the version isn't supported. Something about the fact that it must be manually built and no bugs will be investigated.
  • Update README supported version

0.10 and 0.12 may need their own issues depending on the timing since they EOL October and December respectively.

@xzyfer
Copy link
Contributor

xzyfer commented Sep 7, 2016

We can make reasonable determinations about support from the download count of the release binaries. We get +2M installs a month so we should have a good data. Download counts are exposed via the HG release API.

https://developer.github.com/v3/repos/releases/#get-a-single-release

nschonni added a commit to nschonni/node-sass that referenced this issue Sep 7, 2016
nschonni added a commit to nschonni/node-sass that referenced this issue Sep 7, 2016
@nschonni
Copy link
Contributor Author

nschonni commented Sep 7, 2016

OK, I looked at the 3.8.0 release metrics since it was around for 2 months.
iojs seems to have only ~50 downloads per platform/arch, so I think it is safe to drop now.
5/47 still seems to have quite a few downloads, so I'm thinking that a warning message might be better for now

@xzyfer
Copy link
Contributor

xzyfer commented Sep 7, 2016

Dropping iojs support has come up a few times. My argument has always been that it really costs us nothing to support old version of Node at this point aside from CI time. Is there a particular reason you want to drop older versions?

It's also worth noting we're planning to release LibSass 3.4 soon. This will essentially be a major version bump for LibSass. I was thinking this might be an opportune time to bump the major for node-sass if we had something to land.

@nschonni
Copy link
Contributor Author

nschonni commented Sep 7, 2016

I see it as one of those "why can't I run Windows XP forever things". Yes, it still works, but it's better to encourage people off platforms that don't get security updates anymore (especially devs)

@xzyfer
Copy link
Contributor

xzyfer commented Sep 7, 2016

I don't necessarily agree. It's not hurting anyone, doesn't cause any work for us. Either way I don't feel comfortable dropping any support without a major bump given the most people will lock to ^3.

@xzyfer
Copy link
Contributor

xzyfer commented Sep 8, 2016

Looks like something went wrong here :) Mildly freaked out

@nschonni nschonni reopened this Sep 8, 2016
@nschonni
Copy link
Contributor Author

nschonni commented Sep 8, 2016

Ah, that's what happened #1705 was the one that was supposed to autoclose with that issue

@nschonni nschonni modified the milestones: 4.0, 3.10.0 Sep 8, 2016
xzyfer pushed a commit to xzyfer/node-sass that referenced this issue Sep 8, 2016
@nschonni nschonni modified the milestones: 5.0, 4.0 Jul 14, 2017
@nschonni nschonni changed the title Drop Node 5 support Drop Node EOL versions support Feb 22, 2018
@igor-savin-ht
Copy link

igor-savin-ht commented Apr 23, 2018

@nschonni So which versions are currently in-scope for removing within this issue?

@xzyfer
Copy link
Contributor

xzyfer commented Apr 23, 2018

See #2111

@xzyfer
Copy link
Contributor

xzyfer commented Apr 23, 2018

This has been addressed in #2312

@xzyfer xzyfer closed this as completed Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants