Version 5.0 #2312

xzyfer · 2018-04-03T09:44:12Z

See #2111

Features

Reduce Node version support to Active LTS and Current (@xzyfer) *BREAKING*
Replace Gaze with Chokidar (@xzyfer)
Compile on watch by default (@xzyfer) *BREAKING*
Stop watching and compiling .css files (@xzyfer) *BREAKING*
Allow fallback to local compile on unsupported environments
LibSass 3.6

Misc

Update dependencies (@xzyfer) *BREAKING*
ES6-ify where it improves readability *BREAKING*
Remove deprecated process.sass API (@xzyfer) *BREAKING*
Set engines to supported Node versions ([v5] Indicate the supported Node.js version in package.json #2316, @realityking) *BREAKING*
Remove some Node < 6 work arounds ([v5] Remove workarounds for old Node.js versions #2317, @realityking) *BREAKING*
Remove Object.assign polyfill ([v5] Drop lodash.assign in favor of the native Object.assign #2318, @realityking)
Remove async-foreach dependency (@xzyfer)

Maybe

Official electron support

package.json

This was a non-standared feature in LibSass we had to support. It is being removed in LibSass 3.6.0. This prevents people from output their source directory. See sass/libsass#2611 See #2184 See #2006 See #1933 See #1925 See #1867 See #1845

Four years ago there was a test that mutated `process.cwd` but didn't correctly reset it. The altered global state resulted in future tests having incorrect assetions. I only noticed this because for some reason it manifested in failures in only _some_ Node versions when N-API was being used.

Fixes #2487

xzyfer · 2019-11-07T11:41:59Z

@nschonni @saper I've created the next-major branch. The plan is to merge all the 5.0 milestone changes into that branch so that we can start cutting 5.0 betas with the latest libsass, and trial N-API.

saper · 2019-11-08T23:29:10Z

Is N-API here ready for the prime time? I think have already big changes in, let's not put too many...

xzyfer · 2019-11-08T23:42:14Z

Lots of extensions have moved over. We had issues with node 9 initially but with node >= 10 ci seems happy.

…

On Sat, 9 Nov 2019, 10:29 am Marcin Cieślak, ***@***.***> wrote: Is N-API here ready for the prime time? I think have already big changes in, let's not put too many... — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2312?email_source=notifications&email_token=AAENSWFFMI6CA2BTB5NL4BLQSXY4PA5CNFSM4EYTBPS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDTVERA#issuecomment-552030788>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWBS2P73OAXH2UB2SJLQSXY4PANCNFSM4EYTBPSQ> .

saper · 2019-11-09T00:32:34Z

Sure the code works now - the question is can we release a new binding file with a new version number when the libuv gets upgraded (it gets upgraded pretty often, but rarely breaks compatibility).

I wrap my head around this: https://nodejs.org/api/n-api.html#n_api_implications_of_abi_stability

We include <uv.h> in src/callback_bridge.h and we need it. That probably means we have to check our compatibility with libuv via some other means.

xzyfer · 2019-11-09T02:53:21Z

N-API has async APIs we can use instead of direct libuv
https://nodejs.org/api/n-api.html#n_api_simple_asynchronous_operations

saper · 2019-11-09T13:30:14Z

Yes, we should switch to that. Looks like a non-trivial rewrite to me :(

xzyfer · 2019-11-09T13:33:25Z

Definitely. I think I considered before and ruled it out. I need to refamiliarise myself with the implementation.

…

On Sun, 10 Nov 2019, 12:30 am Marcin Cieślak, ***@***.***> wrote: Yes, we should switch to that. Looks like a non-trivial rewrite to me :( — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2312?email_source=notifications&email_token=AAENSWGIPCATJ2MCMSE7J4DQS23OPA5CNFSM4EYTBPS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUGF3I#issuecomment-552100589>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWCYV3YFTNTKG44WXQDQS23OPANCNFSM4EYTBPSQ> .

saper · 2019-11-09T13:36:15Z

But that means to me we should drop it if we want to kick 5.0 out of the door quickly. Sorry if I am feeling pushy and not contributing enough... :(

xzyfer · 2019-11-09T13:39:33Z

I appreciate your feedback. Node 8 will is in Jan. I agreed we need to understand the trade offs of uv's abi, and do our best to limit the impact. I'll keep digging into it.

…

On Sun, 10 Nov 2019, 12:36 am Marcin Cieślak, ***@***.***> wrote: But that means to me we should drop it if we want to kick 5.0 out of the door quickly. Sorry if I am feeling pushy and not contributing enough... :( — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2312?email_source=notifications&email_token=AAENSWHXEGUQQHFS3R4C6ZLQS24FDA5CNFSM4EYTBPS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUGJXA#issuecomment-552101084>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWG4FO7U4J6BPZKSNN3QS24FDANCNFSM4EYTBPSQ> .

saper · 2019-11-09T13:57:45Z

Sure, I'll have a look at it too.

xzyfer self-assigned this Apr 3, 2018

xzyfer force-pushed the v5 branch 3 times, most recently from 72c51b2 to 0622e7b Compare April 3, 2018 09:48

xzyfer added the v5 label Apr 4, 2018

xzyfer mentioned this pull request Apr 4, 2018

Breaking changes for next major #2111

Closed

nschonni reviewed Apr 4, 2018

View reviewed changes

package.json Outdated Show resolved Hide resolved

This was referenced Apr 4, 2018

[v5] Indicate the supported Node.js version in package.json #2316

Merged

[v5] Remove workarounds for old Node.js versions #2317

Merged

[v5] Drop lodash.assign in favor of the native Object.assign #2318

Merged

xzyfer force-pushed the v5 branch 2 times, most recently from 6dfa324 to 37289ef Compare April 4, 2018 12:46

realityking mentioned this pull request Apr 5, 2018

[v5]Use ES2015 template strings instead of string concatenation. #2322

Closed

xzyfer force-pushed the v5 branch from 606eab0 to 6da31c0 Compare April 16, 2018 13:30

This was referenced Apr 18, 2018

Add ARM CPU architectures #2253

Closed

Drop Node EOL versions support #1709

Closed

Remove process.sass #1856

Closed

YasharF mentioned this pull request Apr 28, 2018

require request 2.85.1 #2356

Closed

johndatserakis mentioned this pull request May 15, 2018

Security issue in dependencies #2355

Closed

Splaktar mentioned this pull request May 17, 2018

build(gulp-sass): update to new version angular/material#11270

Closed

Klooven mentioned this pull request May 17, 2018

Vulnerability in node-sass Tutrox/scss-powertools#20

Closed

netsensei mentioned this pull request May 25, 2018

Security issue in node-sass thedatahub/Datahub#60

Closed

Nateowami mentioned this pull request May 25, 2018

Upgrade node-sass to 4.9.0 sillsdev/web-languageforge#268

Merged

pdkovacs mentioned this pull request Jun 2, 2018

Vulnarabilities due to a transitive dependency on an obsolete version of request ui-toolbox/icon-repository#21

Open

richtier mentioned this pull request Jun 6, 2018

Vulnerable dependency uktrade/directory-sso#243

Closed

xzyfer mentioned this pull request Jun 8, 2018

Contribute to node-sass michaelwayman/node-sass-chokidar#13

Open

msurguy mentioned this pull request Jun 13, 2018

Security vulnerability in one of the dependencies processing/processing-pi-website#1

Open

eritbh mentioned this pull request Jun 14, 2018

Temp fix for reported security vuln ReinaSHSL/wix-maybe#23

Open

brlodi mentioned this pull request Jun 27, 2018

Resolve JS security vulnerability in dependency UrbanCCD-UChicago/plenario2#307

Closed

ntwb mentioned this pull request Jun 28, 2018

Update Node SASS WordPress/gutenberg#7603

Closed

realityking and others added 10 commits November 7, 2019 21:52

Replace lodash/assign in favor of the native Object.assign

4826b59

Indicate the minimum supported Node.js version in package.json

b61e289

Compile on watch

d3d58d7

Don't watch or compile .css files

1af0a2f

This was a non-standared feature in LibSass we had to support. It is being removed in LibSass 3.6.0. This prevents people from output their source directory. See sass/libsass#2611 See #2184 See #2006 See #1933 See #1925 See #1867 See #1845

Bump coveralls@^3.0.7

3930577

Bump glob@^7.1.6

0b959cd

Bump nan@^2.14.0

928dbed

Bump stdout-stream@^1.4.1

0031af2

Bump true-case-path@^2.2.1

6fdfdc6

xzyfer force-pushed the v5 branch from 55a5f73 to 6fdfdc6 Compare November 7, 2019 10:52

xzyfer mentioned this pull request Nov 7, 2019

Replace async-foreach? #2487

Closed

xzyfer force-pushed the v5 branch 2 times, most recently from 910527c to 6b1387c Compare November 7, 2019 11:19

Remove async-foreach dependency

b186df6

Fixes #2487

xzyfer force-pushed the v5 branch from 6b1387c to b186df6 Compare November 7, 2019 11:31

xzyfer changed the base branch from master to next-major November 7, 2019 11:37

xzyfer merged commit e1735cb into next-major Nov 8, 2019

saper mentioned this pull request Nov 9, 2019

Convert binding to N-API #2440

Open

JBallin mentioned this pull request Nov 14, 2020

libsass 3.6 follow-up #3027

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 5.0 #2312

Version 5.0 #2312

xzyfer commented Apr 3, 2018 •

edited

Loading

xzyfer commented Nov 7, 2019

saper commented Nov 8, 2019

xzyfer commented Nov 8, 2019 via email

saper commented Nov 9, 2019 •

edited

Loading

xzyfer commented Nov 9, 2019

saper commented Nov 9, 2019

xzyfer commented Nov 9, 2019 via email

saper commented Nov 9, 2019

xzyfer commented Nov 9, 2019 via email

saper commented Nov 9, 2019

Version 5.0 #2312

Version 5.0 #2312

Conversation

xzyfer commented Apr 3, 2018 • edited Loading

Features

Misc

Maybe

xzyfer commented Nov 7, 2019

saper commented Nov 8, 2019

xzyfer commented Nov 8, 2019 via email

saper commented Nov 9, 2019 • edited Loading

xzyfer commented Nov 9, 2019

saper commented Nov 9, 2019

xzyfer commented Nov 9, 2019 via email

saper commented Nov 9, 2019

xzyfer commented Nov 9, 2019 via email

saper commented Nov 9, 2019

xzyfer commented Apr 3, 2018 •

edited

Loading

saper commented Nov 9, 2019 •

edited

Loading