This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[v5]Use ES2015 template strings instead of string concatenation. #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realityking
force-pushed
the
template-strings
branch
2 times, most recently
from
3362b12
to
bbb6ada
Compare
realityking
changed the title
realityking
force-pushed
the
template-strings
branch
from
bbb6ada
to
6eb814f
Compare
|
I think the |
|
@xzyfer Any feedback on this PR? |
|
Sorry I'm in a European vacation for a couple months. I'll check in on
things when I have my laptop and wifi
…On Fri., 11 May 2018, 12:52 am Rouven Weßling, ***@***.***> wrote:
@xzyfer <https://github.com/xzyfer> Any feedback on this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2322 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWCPwj7Xts1JYnetfNoVKN5P3GXXGks5txMTFgaJpZM4TJEWe>
.
|
It's only used in a test.
realityking
force-pushed
the
template-strings
branch
from
6eb814f
to
7ccd5cd
Compare
|
Rebased for the current |
xzyfer
force-pushed
the
v5
branch
4 times, most recently
from
6b1387c
to
b186df6
Compare
|
You better rebase your fork as there are recent changes to v5. |
|
Thanks for your efforts. We're happy to move forward without this change as it change for changes sake. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think template strings are one of the biggest readability wins of ES2015 and also perfectly supported in Node.js 4.
Relates to #2312