-
Notifications
You must be signed in to change notification settings - Fork 1.3k
support for node.js 12.x #2632
Comments
Updated. We have a PR in #2633 but are blocked on the nodejs team updating nan for Node 12. |
Created a tracking issue nodejs/nan#849 |
Installation and compile is failing on windows. It's works! |
@xzyfer - Looks like the compilation error is originating from that unshimmed v8 string constructor, which is no longer valid. Not actually something NAN updates will fix. You could use https://github.com/nodejs/nan/blob/master/doc/v8_misc.md#nanutf8string though. |
@EricMCornelius I believe the compilation is because that nan API is using the wrong constructor.
|
@xzyfer - I get the error @jiqiangbing highlighted above at: https://github.com/sass/node-sass/blob/master/src/create_string.cpp#L17 during compilation. Aside from that, a clean build from master is working fine on my local. Just changed line #17 to the |
@EricMCornelius even with those changes I was getting build errors locally. Looks like I had an older version on nan when I needed at least 2.13.2 - See https://github.com/nodejs/nan/blob/master/CHANGELOG.md#2132-mar-24-2019
|
Made some tweaks to the PR and kicked off a new round of builds |
CI is happy. Now we're just waiting for appveyor/ci#2921 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@mtimofiiv the branch is ephemeral. Taking that advice will end up in your install breaking when the branch is deleted. Noone needs to use Node 12. The only reasonable solution is to wait. |
Locked this issue since there is no need for further discussion. We know what needs to be done and we're working on it. |
Re-opening because it'll take a day to build the binaries. |
Published as 4.12.0 |
node v12.0.0 just got released: https://nodejs.org/en/blog/release/v12.0.0/
installation is failing on macOS mojave
npm -v
): 6.9.0node -v
): 12.0.0node -p process.versions
): [see below]node -p process.platform
): darwinnode -p process.arch
): x64node -p "require('node-sass').info"
):Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (72)
npm ls node-sass
): node-sass@4.11.0The text was updated successfully, but these errors were encountered: