This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add support for Node 12 #2633
Merged
Add support for Node 12 #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like https://github.com/nodejs/nan doesn't yet support Node 12 so we're blocked on compiling Node 12 binaries. |
|
Created a tracking issue nodejs/nan#849 |
|
Also will need appveyor/ci#2921 |
xzyfer
force-pushed
the
node-12
branch
2 times, most recently
from
9d820c1 to
b110d0b
Compare
nschonni
reviewed
Apr 25, 2019
nschonni
reviewed
Apr 25, 2019
|
Got this green using the workaround from appveyor/ci#2921 (comment). Hopefully this should mean no more waiting for AppVeyor. |
|
Might want to update the package.json with this, unless you are going to do that separately before tagging |
|
Bumped package.json on master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2632