-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use libstdc++.so.6.0.9 to workaround static init problems #1110
Conversation
Allow to link the binding against oldish libstdc++.6.0.9 installed on MacOSX (from gcc 4.2.1)
IIRC this would ideally be superseded by nodejs/nan#431? |
Remove C++11 feature in order to be able to compile against libstdc++.so.6.0.9 on MacOSX.
@xzyfer can you check if this compiles, and if it does, does it crash with stock nan 2.0.7 (without nodejs/nan#431 applied) |
This appears to work @saper |
Yay! :happy: |
Do you have objections to the nan patch? Doesn't look like we can avoid it
|
f67b8aa
to
44ebb6a
Compare
As to relation to nodejs/nan#431: nan use of static revealed an incompatibility between C++ libraries or a linker/compiler bug. This can be to a large extent avoided by this patch here. There is a possibility that some other binary component (not necessarily nan) introduces a feature that breaks again, so we should stay on a safe side. |
I'm happy for you to ship this. I'm for about 16hrs. Feel free to merge and
|
So we are about to get 3.3.2 soon :) |
@xzyfer would be cool if you were able to check |
We've tried to get OSX CI but we were denied by the Travis team. I'll chase them up again. |
Add a join us in slack button to the readme
libsass needs to be linked against libc++ from clang
on MacOSX to use advanced C++11 functions.
The binding code is not that picky and we can try
to link against whatever is the default.
Mixing C++ runtime libraries is still very bad, but
we should be able to avoid crash when being
used with another node module using nan.h
and its GetWrapper() static cache:
fsevents/fsevents#82