Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage specs for Dart Sass. #1129

Merged
merged 6 commits into from
May 29, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
:nth-of-type(2n- 1),
:nth-of-type(2n -1),
:nth-of-type(2n - 1),
:nth-of-type(2n - 1 ) {
:nth-of-type(2n - 1) {
color: red;
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
:nth-of-type(2n+ 1),
:nth-of-type(2n +1),
:nth-of-type(2n + 1),
:nth-of-type(2n + 1 ) {
:nth-of-type(2n + 1) {
color: red;
}
3 changes: 0 additions & 3 deletions spec/libsass-closed-issues/issue_2000/options.yml

This file was deleted.

4 changes: 4 additions & 0 deletions spec/libsass-closed-issues/issue_2365/error-dart-sass
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Error: expected selector.
},
^
spec/libsass-issues/issue_2365/input.scss 4:6 root stylesheet
3 changes: 0 additions & 3 deletions spec/libsass-closed-issues/issue_2365/options.yml

This file was deleted.

170 changes: 170 additions & 0 deletions spec/libsass-closed-issues/issue_2374/error-dart-sass
Original file line number Diff line number Diff line change
@@ -0,0 +1,170 @@
WARNING on line 7, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} { background-color: lighten($color, $amount) };
^^^^^

WARNING on line 7, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} { background-color: lighten($color, $amount) };
^^^^^

WARNING on line 7, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} { background-color: lighten($color, $amount) };
^^^^^

WARNING on line 7, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} { background-color: lighten($color, $amount) };
^^^^^

WARNING on line 7, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} { background-color: lighten($color, $amount) };
^^^^^

WARNING on line 7, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} { background-color: lighten($color, $amount) };
^^^^^

WARNING on line 7, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} { background-color: lighten($color, $amount) };
^^^^^

WARNING on line 7, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} { background-color: lighten($color, $amount) };
^^^^^

WARNING on line 7, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} { background-color: lighten($color, $amount) };
^^^^^

WARNING on line 7, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} { background-color: lighten($color, $amount) };
^^^^^

WARNING on line 20, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} {
^^^^^

WARNING on line 20, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} {
^^^^^

WARNING on line 20, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value yellow in interpolation here.
It may end up represented as yellow, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "yellow").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} {
^^^^^

WARNING on line 20, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value red in interpolation here.
It may end up represented as red, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "red").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} {
^^^^^

WARNING on line 20, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value red in interpolation here.
It may end up represented as red, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "red").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} {
^^^^^

WARNING on line 20, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value red in interpolation here.
It may end up represented as red, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "red").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} {
^^^^^

WARNING on line 20, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value blue in interpolation here.
It may end up represented as blue, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "blue").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} {
^^^^^

WARNING on line 20, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value blue in interpolation here.
It may end up represented as blue, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "blue").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} {
^^^^^

WARNING on line 20, column 12 of spec/libsass-issues/issue_2374/input.scss:
You probably don't mean to use the color value blue in interpolation here.
It may end up represented as blue, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "blue").
If you really want to use the color value here, use '"" + $name'.

.#{$name}-#{($i*100)} {
^^^^^
3 changes: 0 additions & 3 deletions spec/libsass-closed-issues/issue_2374/options.yml

This file was deleted.

2 changes: 1 addition & 1 deletion spec/libsass-closed-issues/issue_698/options.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
---
:todo:
:ignore_for:
- dart-sass
11 changes: 11 additions & 0 deletions spec/libsass-todo-issues/issue_2055/expected_output-dart-sass.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
:not(.thing) {
color: red;
}

:not(.thing[disabled]):not([disabled]:has(:not(.thing[disabled]):not([disabled]:not(.thing[disabled])))):not([disabled]:not(.thing[disabled]):not([disabled]:has(:not(.thing[disabled]):not([disabled]:not(.thing[disabled]))))) {
background: blue;
}

:has(:not(.thing[disabled]):not([disabled]:has(:not(.thing[disabled]):not([disabled]:not(.thing[disabled])))):not([disabled]:not(.thing[disabled]):not([disabled]:has(:not(.thing[disabled]):not([disabled]:not(.thing[disabled])))))) {
background: blue;
}
3 changes: 0 additions & 3 deletions spec/libsass-todo-issues/issue_2055/options.yml

This file was deleted.

Empty file.
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
.item {
display: inline-block;
}
.item :global(> .ext-link) {
background: #000;
}

.link, .textLink {
color: red;
}

.textLink {
padding: 0 10px;
}
3 changes: 0 additions & 3 deletions spec/libsass-todo-issues/issue_2366/global/options.yml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ a b :first-child ::after, a b :nth-of-type(-2n+1) ::after {
a b :first-child :not(.foo), a b :nth-of-type(-2n+1) :not(.foo) {
hoo: boo;
}
a b :first-child , a b :nth-of-type(-2n+1) {
hoo: boo;
}
a b :first-child a, a b :nth-of-type(-2n+1) a {
b: c;
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ a b {
:not(.foo) {
hoo: boo;
}
// the following is not actually valid, but sass accepts it
:not(:not(:not(.foo[bleeble="blabble"] > .hello, .gluxbux))) { hoo: boo; }
a { b: c; }
}
}

This file was deleted.

2 changes: 1 addition & 1 deletion spec/libsass/inheritance/options.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
---
:todo:
:ignore_for:
- dart-sass
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
---
:todo:
:ignore_for:
- dart-sass
3 changes: 0 additions & 3 deletions spec/selector-functions/extend/simple/options.yml

This file was deleted.

3 changes: 0 additions & 3 deletions spec/selector-functions/replace/options.yml

This file was deleted.