Sort input file list #178
Merged
Sort input file list #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that libsass.so builds in a reproducible way in spite of indeterministic filesystem readdir order. See https://reproducible-builds.org/ for why this is good. This PR was done while working on reproducible builds for openSUSE.
|
@glebm could you please review this PR? |
|
I think the PR is ok, see https://bugs.ruby-lang.org/issues/8709 for more context |
glebm
approved these changes
Mar 3, 2020
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 17, 2020
Update to ruby-sassc to 2.3.0. - **2.3.0** - [Fix rake gem:native task](sass/sassc-ruby#196) - [disable lto flag for darwin + nix](sass/sassc-ruby#166) - [Sort input file list](sass/sassc-ruby#178) - [Set appropriate encoding for source_map](sass/sassc-ruby#152) - [allow passing functions directly](sass/sassc-ruby#162) - [always dispose data context](sass/sassc-ruby#161) - [Update libsass to 3.6.3](sass/sassc-ruby#164) - [Restore strip symbols](sass/sassc-ruby#184) - [Default --march-tune-native to false](sass/sassc-ruby#158) - [Fix compile issue on Mac OS X](sass/sassc-ruby#174) - [Test on TruffleRuby in TravisCI](sass/sassc-ruby#171) - [Use RbConfig::MAKEFILE_CONFIG['DLEXT'] instead of hardcoding extensions](sass/sassc-ruby#173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort input file list
so that
libsass.sobuilds in a reproducible wayin spite of indeterministic filesystem readdir order.
See https://reproducible-builds.org/ for why this is good.
This PR was done while working on reproducible builds for openSUSE.
Package is called
rubygem-sasscthere.The only other problem is that
--disable-march-tune-nativeis not the default, so results vary depending on build worker CPU. Could also be selected if theSOURCE_DATE_EPOCHenv var is set.