-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rake gem:native task #196
Conversation
3d71957
to
72bef57
Compare
Additionally f26f2a1 removed precompilation for linux, so really the only precompilation left is I tested it locally and it works:
|
A better fix would be to remove this install command: Line 41 in 0cb5c9e
This is now handled in rake-compiler itself |
72bef57
to
e1ac6cc
Compare
Well, that's what this PR does. I pushed a new commit that adds |
Please update the commit message as well |
e1ac6cc
to
ee8154d
Compare
RIght, good point. Done. |
Thanks. Will release tomorrow morning assuming i don't run into any issues. |
Release complete, thanks for the help! |
Update to ruby-sassc to 2.3.0. - **2.3.0** - [Fix rake gem:native task](sass/sassc-ruby#196) - [disable lto flag for darwin + nix](sass/sassc-ruby#166) - [Sort input file list](sass/sassc-ruby#178) - [Set appropriate encoding for source_map](sass/sassc-ruby#152) - [allow passing functions directly](sass/sassc-ruby#162) - [always dispose data context](sass/sassc-ruby#161) - [Update libsass to 3.6.3](sass/sassc-ruby#164) - [Restore strip symbols](sass/sassc-ruby#184) - [Default --march-tune-native to false](sass/sassc-ruby#158) - [Fix compile issue on Mac OS X](sass/sassc-ruby#174) - [Test on TruffleRuby in TravisCI](sass/sassc-ruby#171) - [Use RbConfig::MAKEFILE_CONFIG['DLEXT'] instead of hardcoding extensions](sass/sassc-ruby#173)
As discussed in #195,
rake gem:native
is currently broken, preventing a new release.The error is:
I looked around and apparently this package is outdated an no longer available. However it's used for cross compiling for 32bit packages.
If we looked at downloaded packages:
I think it's safe to say that close to nobody downloads the 32 bits binaries, and for the few people who do, AFAIK it should fallback somewhat nicely to compiling from source.
All that to say that I think it's OK to drop it.
cc @bolandrm @rafaelfranca