Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ordering issue #1390

Merged
merged 11 commits into from
Jun 22, 2022
Merged

Fix ordering issue #1390

merged 11 commits into from
Jun 22, 2022

Commits on Jun 22, 2022

  1. ### What's done: WIP

    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    0dcde7e View commit details
    Browse the repository at this point in the history

  2. Fix ordering issue 

    - added ruleSetId to Rule.VisitorModifier.RunAfterRule
- extracted ordering logic to OrderedRuleSet
- removed all prefixes in rule_id
    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    b051237 View commit details
    Browse the repository at this point in the history

  3. Fix ordering issue 

    ### What's done:
- added ruleSetId to Rule.VisitorModifier.RunAfterRule
- extracted ordering logic to OrderedRuleSet
- removed all prefixes in rule_id
    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    69bc989 View commit details
    Browse the repository at this point in the history

  4. added test for ktlint and ordering

    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    ab64610 View commit details
    Browse the repository at this point in the history

  5. added test for ktlint and ordering

    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    4e3a0f8 View commit details
    Browse the repository at this point in the history

  6. removed DummyWarningRule

    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    ea51736 View commit details
    Browse the repository at this point in the history

  7. reverted changes committed by mistake

    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    5d4d492 View commit details
    Browse the repository at this point in the history

  8. fixed failed test

    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    dadb5a7 View commit details
    Browse the repository at this point in the history

  9. fixed static code issues

    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    b575710 View commit details
    Browse the repository at this point in the history

  10. fixed static code issues #2

    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    9ff660a View commit details
    Browse the repository at this point in the history

  11. fixed static code issues #3

    @nulls
    nulls committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    f9d2bd9 View commit details
    Browse the repository at this point in the history