Ignore external interfaces when triggering EXTENSION_FUNCTION_WITH_CLASS
#1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_CLASS` ### What's done: - Fixes #1586
Codecov Report
@@ Coverage Diff @@
## master #1630 +/- ##
============================================
+ Coverage 82.47% 82.50% +0.02%
- Complexity 2334 2335 +1
============================================
Files 112 112
Lines 7862 7892 +30
Branches 2045 2048 +3
============================================
+ Hits 6484 6511 +27
Misses 452 452
- Partials 926 929 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0x6675636b796f75676974687562
requested review from
nulls,
sanyavertolet,
Cheshiriks and
icemachined
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 166 files ±0 166 suites ±0 28m 23s ⏱️ + 2m 33s For more details on these failures, see this check. Results for commit 4d47318. ± Comparison against base commit 82ee915. ♻️ This comment has been updated with latest results. |
Cheshiriks
approved these changes
Mar 17, 2023
0x6675636b796f75676974687562
deleted the
bugfix/andrey.shcheglov/external-interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
EXTENSION_FUNCTION_WITH_CLASSfalse positive with external interfaces #1586