Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have AttributesAPI ApplyPhraseToUser return new DTO with success, error, approved, rejected, in review fields #289

Open
mrsbluerose opened this issue Oct 1, 2024 · 1 comment · Fixed by #292
Open

Have AttributesAPI ApplyPhraseToUser return new DTO with success, error, approved, rejected, in review fields #289

mrsbluerose opened this issue Oct 1, 2024 · 1 comment · Fixed by #292
Assignees
@mrsbluerose

Comments

@mrsbluerose
Copy link
Collaborator

mrsbluerose commented Oct 1, 2024 •
edited
Loading

Have Attributes API return new dto - success, error, approved, rejected, in review fields
Check exception, bad request and return in error
Add third user Notification for in review
(logic from service should return true/false for whether phrase was approved or added to ToBeReviewed)

Relates to #288
@mrsbluerose mrsbluerose self-assigned this Oct 1, 2024
@mrsbluerose mrsbluerose moved this to In Progress in TribeApp Project Oct 1, 2024
@mrsbluerose mrsbluerose changed the title Have AttributesAPI return new DTO with success, error, approved, rejected, in review fields Have AttributesAPI ApplyPhraseToUser return new DTO with success, error, approved, rejected, in review fields Oct 1, 2024
@mrsbluerose
Copy link
Collaborator Author

per meeting 10/1:
remove logic for returning an error (unnecessary)
place dto builder logic in service

This was linked to pull requests Oct 3, 2024
TRIB-289: Refactors AttributeAPI applyPhraseToUser endpoint and all related services to use a DTO #290
Closed
TRIB-289: adds AttributesApplyPhraseToUser DTO and in review notification #292
Merged
@mrsbluerose mrsbluerose mentioned this issue Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrsbluerose mrsbluerose

Labels
None yet
Projects
TribeApp Project
Status: In QA
Milestone
No milestone
1 participant
@mrsbluerose