TRIB-289: Refactors AttributeAPI applyPhraseToUser endpoint and all related services to use a DTO #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactors PhraseService.applyPhraseToUser to return AttributesApplyPhraseToUserDTO
- refactors with new return type of AttributesApplyPhraseToUserDTO - note: fixes logic error for testApplyPhraseToUserWhenPhraseDoesNotExistInToBeReviewed which was incorrectly finding a phrase in toBeReviewed repository
- removes context="test" from changelog-202309050841.xml - reasoning: these are notification constants
- adds type for in review
This reverts commit 1a5b26c.
- adds constructAttributesApplyPhraseToUserDTO to PhraseService interface to be used by AttributesAPIController
- refactors AttributesAPIController applyPhraseToUser with AttributesApplyPhraseToUserDTO - refactors sendNotification with in review notification and AttributesApplyPhraseToUserDTO
- refactors applyPhraseToUser tests with AttributeApplyPhraseToUserDTO
- refactors AttributeApplyPhraseToUserDTO isSuccess field to be true when phrase added to toBeReviewed - fixes tests to reflect this change
- adds testConstructPhraseDTPFromPhraseInformationWhenPhraseHasAllFourWords and testConstructPhraseDTPFromPhraseInformationWhenPhraseOnlyHasVerbAndNoun
- adds testConstructAttributesApplyPhraseToUserDTO
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/review-attributes-page #290 +/- ##
====================================================================
- Coverage 82.55% 82.54% -0.01%
- Complexity 556 559 +3
====================================================================
Files 79 80 +1
Lines 1685 1690 +5
Branches 275 276 +1
====================================================================
+ Hits 1391 1395 +4
Misses 254 254
- Partials 40 41 +1 ☔ View full report in Codecov by Sentry. |
haxwell
reviewed
Oct 4, 2024
| @@ -7,6 +7,7 @@ | |||
| public class NotificationType { | |||
|
|
|||
| public static final NotificationType ATTRIBUTE_REQUEST_APPROVED = new NotificationType(1L, "Attribute request approved", null); | |||
| public static final NotificationType ATTRIBUTE_REQUEST_IN_REVIEW = new NotificationType(1L, "Attribute request in review", null); | |||
There was a problem hiding this comment.
There was a bug in the previous version.. This ID should be unique, instead of 1L
- refactors PhraseService.applyPhraseToUser to return AttributesApplyPhraseToUserDTO
- refactors with new return type of AttributesApplyPhraseToUserDTO - note: fixes logic error for testApplyPhraseToUserWhenPhraseDoesNotExistInToBeReviewed which was incorrectly finding a phrase in toBeReviewed repository
- removes context="test" from changelog-202309050841.xml - reasoning: these are notification constants
- adds type for in review
This reverts commit 1a5b26c.
- adds constructAttributesApplyPhraseToUserDTO to PhraseService interface to be used by AttributesAPIController
- refactors AttributesAPIController applyPhraseToUser with AttributesApplyPhraseToUserDTO - refactors sendNotification with in review notification and AttributesApplyPhraseToUserDTO
- refactors applyPhraseToUser tests with AttributeApplyPhraseToUserDTO
- refactors AttributeApplyPhraseToUserDTO isSuccess field to be true when phrase added to toBeReviewed - fixes tests to reflect this change
- adds testConstructPhraseDTPFromPhraseInformationWhenPhraseHasAllFourWords and testConstructPhraseDTPFromPhraseInformationWhenPhraseOnlyHasVerbAndNoun
- adds testConstructAttributesApplyPhraseToUserDTO
|
closing due to errors on local. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing: