-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRIB-289: adds AttributesApplyPhraseToUser DTO and in review notification #292
Merged
haxwell
merged 27 commits into
savvato-software:feature/review-attributes-page
from
mrsbluerose:TRIB-289
Oct 25, 2024
Merged
TRIB-289: adds AttributesApplyPhraseToUser DTO and in review notification #292
haxwell
merged 27 commits into
savvato-software:feature/review-attributes-page
from
mrsbluerose:TRIB-289
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactors PhraseService.applyPhraseToUser to return AttributesApplyPhraseToUserDTO
- refactors with new return type of AttributesApplyPhraseToUserDTO - note: fixes logic error for testApplyPhraseToUserWhenPhraseDoesNotExistInToBeReviewed which was incorrectly finding a phrase in toBeReviewed repository
- removes context="test" from changelog-202309050841.xml - reasoning: these are notification constants
- adds type for in review
This reverts commit 1a5b26c.
- adds constructAttributesApplyPhraseToUserDTO to PhraseService interface to be used by AttributesAPIController
- refactors AttributesAPIController applyPhraseToUser with AttributesApplyPhraseToUserDTO - refactors sendNotification with in review notification and AttributesApplyPhraseToUserDTO
- refactors applyPhraseToUser tests with AttributeApplyPhraseToUserDTO
- refactors AttributeApplyPhraseToUserDTO isSuccess field to be true when phrase added to toBeReviewed - fixes tests to reflect this change
- adds testConstructPhraseDTPFromPhraseInformationWhenPhraseHasAllFourWords and testConstructPhraseDTPFromPhraseInformationWhenPhraseOnlyHasVerbAndNoun
- adds testConstructAttributesApplyPhraseToUserDTO
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/review-attributes-page #292 +/- ##
====================================================================
- Coverage 82.24% 82.22% -0.02%
- Complexity 568 570 +2
====================================================================
Files 81 82 +1
Lines 1729 1733 +4
Branches 276 277 +1
====================================================================
+ Hits 1422 1425 +3
Misses 267 267
- Partials 40 41 +1 ☔ View full report in Codecov by Sentry. |
- jacoco report confirms that helper methods are covered in the other tests
10ab2c0
into
savvato-software:feature/review-attributes-page
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
NOTE: changes data returned to the frontend!
Old implementation:
returned GenericResponseDTO.BooleanMessage
New implementation:
returns AttributesApplyPhraseToUserDTO with one field set to true and the rest to false.