fix(sbb-select): respect text node mutations for displayed value #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
target: 2.x
pr: peer review required
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
github-actions
bot
added
the
pr: lead review approved
jeripeierSBB
commented
Jan 6, 2025
github-actions
bot
added
pr: visual review required
and removed
pr: visual review required
labels
github-actions
bot
removed
the
pr: peer review required
sbb-design-systems-bot bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
The former fix did not consider an update to a text node, which doesn't trigger a slotchange. This PR changes to mutationObserver where all the mutations should be respected. Closes #3298
jeripeierSBB
pushed a commit
that referenced
this pull request
Jan 16, 2025
🤖 I have created a release *beep* *boop* --- ## [2.1.0](v2.0.3...v2.1.0) (2025-01-16) ### Features * improve stacking context for overlay components ([#3349](#3349)) ([7ea0640](7ea0640)) * **sbb-container, sbb-sticky-bar:** add 'midnight' and 'charcoal' color variants ([#3337](#3337)) ([6eee274](6eee274)) * **sbb-dialog:** introduce `backdrop` property to control backdrop density ([#3325](#3325)) ([813b141](813b141)), closes [#2806](#2806) * **sbb-menu:** improvements on arrow navigation ([#3341](#3341)) ([d90364f](d90364f)) ### Bug Fixes * fix active color of buttons ([#3327](#3327)) ([4a13b78](4a13b78)) * handle datepicker association reliably ([#3339](#3339)) ([be060fb](be060fb)), closes [#3331](#3331) * **sbb-select:** handle properties change ([#3334](#3334)) ([d6b914a](d6b914a)) * **sbb-select:** respect text node mutations for displayed value ([#3329](#3329)) ([707366a](707366a)), closes [#3298](#3298) ### Documentation * fix radio button group change event usages ([#3330](#3330)) ([c5657de](c5657de)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former fix did not consider an update to a text node, which doesn't trigger a slotchange. This PR changes to mutationObserver where all the mutations should be respected.
Closes #3298