Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-menu): improvements on arrow navigation #3341

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

DavideMininni-Fincons
Copy link
Contributor

No description provided.

Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jan 14, 2025
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving here!

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jan 14, 2025
@DavideMininni-Fincons DavideMininni-Fincons merged commit 795d94d into main Jan 14, 2025
29 of 30 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/menu-navigation-arrow branch January 14, 2025 11:32
jeripeierSBB pushed a commit that referenced this pull request Jan 16, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](v2.0.3...v2.1.0)
(2025-01-16)


### Features

* improve stacking context for overlay components
([#3349](#3349))
([7ea0640](7ea0640))
* **sbb-container, sbb-sticky-bar:** add 'midnight' and 'charcoal' color
variants
([#3337](#3337))
([6eee274](6eee274))
* **sbb-dialog:** introduce `backdrop` property to control backdrop
density
([#3325](#3325))
([813b141](813b141)),
closes
[#2806](#2806)
* **sbb-menu:** improvements on arrow navigation
([#3341](#3341))
([d90364f](d90364f))


### Bug Fixes

* fix active color of buttons
([#3327](#3327))
([4a13b78](4a13b78))
* handle datepicker association reliably
([#3339](#3339))
([be060fb](be060fb)),
closes
[#3331](#3331)
* **sbb-select:** handle properties change
([#3334](#3334))
([d6b914a](d6b914a))
* **sbb-select:** respect text node mutations for displayed value
([#3329](#3329))
([707366a](707366a)),
closes
[#3298](#3298)


### Documentation

* fix radio button group change event usages
([#3330](#3330))
([c5657de](c5657de))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available target: 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

menu: unit tests about keyboard navigation should be added
3 participants